Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating library #4728

Merged
merged 3 commits into from
Jan 28, 2022
Merged

updating library #4728

merged 3 commits into from
Jan 28, 2022

Conversation

luu-alex
Copy link
Contributor

No description provided.

@render
Copy link

render bot commented Jan 24, 2022

Your Render PR Server URL is https://web3-js-pr-4728.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c7ni5gfho1khtk3avop0.

@coveralls
Copy link

coveralls commented Jan 24, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1757992025

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.762%
Totals Coverage Status
Change from base Build 1755135629: 0.0%
Covered Lines: 3385
Relevant Lines: 4397
💛 - Coveralls

spacesailor24
spacesailor24 previously requested changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@spacesailor24 spacesailor24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated to:

-  Ran `npm audit fix` to address vulnerabilities and update libraries (#4719) (#4728)

@luu-alex luu-alex requested a review from nazarhussain January 27, 2022 19:07
@luu-alex luu-alex merged commit 314e1b5 into 1.x Jan 28, 2022
@luu-alex luu-alex deleted the update-library branch January 28, 2022 15:15
@nazarhussain nazarhussain mentioned this pull request Feb 3, 2022
Closed
@jdevcs jdevcs mentioned this pull request Feb 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazarhussain nazarhussain nazarhussain approved these changes

@jdevcs jdevcs jdevcs approved these changes

@spacesailor24 spacesailor24 Awaiting requested review from spacesailor24

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luu-alex @coveralls @nazarhussain @spacesailor24 @jdevcs