-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example import for package level types #4611
Conversation
I couldn't find an example import for package level types documented elsewhere
Hi @jgresham Thanks for contribution. I posted some feedback. In addition to it I suggest you to create an issue on Github repo and link your PR to it. Also create an entry to |
@nazarhussain When I wanted to import the |
@jgresham As we are focused on |
I couldn't find an example import for package level types documented elsewhere
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.