-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a typo #4599
Merged
Merged
Fix a typo #4599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@chenxsan Thanks a lot for your contribution. The change seems good, I assigned some reviewers to get this approved so we can merge it. Meanwhile I would request you to create an issue on and link your PR with that issue. Also create an entry into |
nazarhussain
approved these changes
Dec 9, 2021
nazarhussain
approved these changes
Dec 10, 2021
luu-alex
approved these changes
Dec 13, 2021
Closed
1 task
jdevcs
approved these changes
Dec 17, 2021
jdevcs
pushed a commit
that referenced
this pull request
Dec 17, 2021
* Empty commit to trigger CI * Fix a typo (#4599) * Fix a typo * update changelog Co-authored-by: Nazar Hussain <[email protected]> * 📝 Update the chanelog for 1.7.1 Co-authored-by: Sam Chen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Seems a whitespace is needed to render the code part correctly:
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.