-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add berlin tx support #4083
add berlin tx support #4083
Conversation
Your Render PR Server URL is https://web3-js-pr-4083.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c2mj9fu31hsclcu0cga0. |
This pull request introduces 1 alert when merging d965f2e into 1ed3c68 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 27f53e8 into 1ed3c68 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging b1446c3 into 1ed3c68 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging c61dd9c into 1ed3c68 - view on LGTM.com new alerts:
|
Pull Request Test Coverage Report for Build 893882309
💛 - Coveralls |
This pull request introduces 1 alert when merging bdedfa4 into 1ed3c68 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 8954009 into 1ed3c68 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dist/
files were updated, but should only be updated upon release, otherwise, it looks good!
This pull request introduces 1 alert when merging b005b0a into 1ed3c68 - view on LGTM.com new alerts:
|
Currently blocked by ethereumjs/ethereumjs-monorepo#1292 but local testing shows it solves our problems 🎊 |
Description
Adds berlin tx support.
Notes about tests:
Since the new transaction type changes how the transactions are RLP'd some of the messages hashes needed to be updated. Only test cases with
error: false
(or omitted completely) will run successfully in the first place, and thus tests witherror: true
did not need to be updated.closes #3963
closes #4012 (supersedes)
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.