Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3425 #3989

Closed
wants to merge 2 commits into from
Closed

Fix #3425 #3989

wants to merge 2 commits into from

Conversation

koraykoska
Copy link

Added the custom error

Description

Fixes #3425 with a custom error.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Added the custom error
@render
Copy link

render bot commented Apr 5, 2021

@lgtm-com
Copy link

lgtm-com bot commented Apr 5, 2021

This pull request introduces 2 alerts when merging 357b89f into 888d107 - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Variable not declared before use

@coveralls
Copy link

coveralls commented Apr 5, 2021

Pull Request Test Coverage Report for Build 854110634

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 12 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 76.208%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/web3-core-helpers/src/errors.js 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
packages/web3-core-helpers/src/errors.js 1 1.54%
packages/web3-core-helpers/lib/errors.js 4 86.96%
packages/web3-providers-http/lib/index.js 7 75.29%
Totals Coverage Status
Change from base Build 849889899: -0.04%
Covered Lines: 3159
Relevant Lines: 3934

💛 - Coveralls

@spacesailor24
Copy link
Contributor

@GregTheGreek I think a really good point was made here and it would be irresponsible to merge this in as a patch version

Copy link
Contributor

@spacesailor24 spacesailor24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG.md needs to be updated, but we might need to think about releasing this as apart of 3.x or something

@github-actions
Copy link

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Jul 18, 2021
@mpetrunic mpetrunic deleted the fix/xmlhttp branch October 31, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Has not received enough activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XMLHttpRequest errors are not handled correctly
4 participants