-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3425 #3989
Fix #3425 #3989
Conversation
Your Render PR Server URL is https://web3-js-pr-3989.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c1lbat3jbvm75oevrtcg. |
This pull request introduces 2 alerts when merging 357b89f into 888d107 - view on LGTM.com new alerts:
|
Pull Request Test Coverage Report for Build 854110634
💛 - Coveralls |
@GregTheGreek I think a really good point was made here and it would be irresponsible to merge this in as a patch version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHANGELOG.md
needs to be updated, but we might need to think about releasing this as apart of 3.x
or something
This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
Added the custom error
Description
Fixes #3425 with a custom error.
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.