Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use posinstall to do deprecation warnings #3917

Merged
merged 6 commits into from
Mar 16, 2021
Merged

use posinstall to do deprecation warnings #3917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0e28a36
use posinstall to do deprecation warnings
frankiebee Feb 22, 2021
948f5e8
add to change log
frankiebee Feb 22, 2021
d1345ec
add preinstall warning
frankiebee Feb 22, 2021
e30e048
remove preinstall
frankiebee Mar 1, 2021
5a6c4f1
add warnings to bzz and shh package.json
frankiebee Mar 9, 2021
d80c211
Merge branch '1.x' into warnings
spacesailor24 Mar 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,5 +361,6 @@ Released with 1.0.0-beta.37 code base.
### Changed

- Unified babel compiler for `web3-eth2-core` and `web3-eth2-beaconchain` (#3892)
- moved deprecation warnings to postinstall scripts (#3917)
- Upgrade `@chainsafe/geth-dev-assistant` from `0.1.5` to `0.1.9` (#3950)
- Replaced hardcoded infura link with Github Secret for some tests (#3943)
3 changes: 2 additions & 1 deletion packages/web3-bzz/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
"types": "types/index.d.ts",
"scripts": {
"tsc": "tsc -b tsconfig.json",
"dtslint": "dtslint --localTs ../../node_modules/typescript/lib types"
"dtslint": "dtslint --localTs ../../node_modules/typescript/lib types",
"postinstall": "echo \"WARNING: the web3-bzz api will be deprecated in the next version\""
},
"main": "lib/index.js",
"dependencies": {
Expand Down
4 changes: 0 additions & 4 deletions packages/web3-bzz/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ var swarm = require("swarm-js");

var Bzz = function Bzz(provider) {


console.warn('web3-bzz package will be deprecated in version 1.3.5 and will no longer be supported.')


this.givenProvider = Bzz.givenProvider;

if (provider && provider._requestManager) {
Expand Down
3 changes: 2 additions & 1 deletion packages/web3-shh/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
"types": "types/index.d.ts",
"scripts": {
"tsc": "tsc -b tsconfig.json",
"dtslint": "dtslint --localTs ../../node_modules/typescript/lib types"
"dtslint": "dtslint --localTs ../../node_modules/typescript/lib types",
"postinstall": "echo \"WARNING: the web3-shh api will be deprecated in the next version\""
},
"main": "lib/index.js",
"dependencies": {
Expand Down
3 changes: 0 additions & 3 deletions packages/web3-shh/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ var Net = require('web3-net');
var Shh = function Shh() {


console.warn('web3-shh package will be deprecated in version 1.3.5 and will no longer be supported.')


var _this = this;

// sets _requestmanager
Expand Down
3 changes: 2 additions & 1 deletion packages/web3/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
"types": "types/index.d.ts",
"scripts": {
"tsc": "tsc -b tsconfig.json",
"dtslint": "dtslint --localTs ../../node_modules/typescript/lib types"
"dtslint": "dtslint --localTs ../../node_modules/typescript/lib types",
"postinstall": "echo \"WARNING: the web3-shh and web3-bzz api will be deprecated in the next version\""
},
"authors": [
{
Expand Down