Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callback for onNewProviderDiscovered Should Have EIP6963ProvidersMapUpdateEvent Parameter #7241

Closed
danforbes opened this issue Sep 5, 2024 · 0 comments · Fixed by #7242
Closed

Callback for onNewProviderDiscovered Should Have EIP6963ProvidersMapUpdateEvent Parameter #7241

danforbes opened this issue Sep 5, 2024 · 0 comments · Fixed by #7242
Assignees
@danforbes
Labels
4.x 4.0 related Bug Addressing a bug

Comments

@danforbes
Copy link
Contributor

The callback for the static Web3.onNewProviderDiscovered function should have a parameter of type EIP6963ProvidersMapUpdateEvent as opposed to EIP6963AnnounceProviderEvent.
@danforbes danforbes self-assigned this Sep 5, 2024
danforbes added a commit that referenced this issue Sep 5, 2024
@danforbes
fix(onNewProviderDiscovered): callback-parameter
69555b4 
Callback for `onNewProviderDiscovered`should have `EIP6963ProvidersMapUpdateEvent` parameter

Closes #7241
@danforbes danforbes mentioned this issue Sep 5, 2024
Merged
danforbes added a commit that referenced this issue Sep 9, 2024
@danforbes
fix(onNewProviderDiscovered): callback-parameter (#7242)
27155ea 
* fix(onNewProviderDiscovered): callback-parameter

Callback for `onNewProviderDiscovered`should have `EIP6963ProvidersMapUpdateEvent` parameter

Closes #7241

* Update Changelog

* Fix Changelog

* Remove Unnecessary Whitespace
@mconnelly8 mconnelly8 added Bug Addressing a bug 4.x 4.0 related labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danforbes danforbes

Labels
4.x 4.0 related Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(onNewProviderDiscovered): callback-parameter web3/web3.js
2 participants
@danforbes @mconnelly8