-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventLog.removed has not been typed #4747
Comments
Thanks @hellowodl for reaching to us with the issue. We would encourage if you create a pull request for it, or we will plan it further considering our capacity. |
I also need |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
* Add `removed` property to `Log` type Fixes #4747 (comment) * Update CHANGELOG.md added this upon jdevcs' [request](#4877 (comment)) * Update CHANGELOG.md Co-authored-by: Junaid <[email protected]>
* Add `removed` property to `Log` type Fixes #4747 (comment) * Update CHANGELOG.md added this upon jdevcs' [request](#4877 (comment)) * Update CHANGELOG.md Co-authored-by: Junaid <[email protected]> Co-authored-by: Samuel Laferriere <[email protected]>
Is there an existing issue for this?
Current Behavior
Listening to web3.eth.Contract.events.Event.on('changed', EventLog => {}) returns an EventLog without { removed: boolean }.
Web3's type definitions don't account for
removed
to exist.Expected Behavior
The EventLog on the
changed
event, should return { removed: boolean } as well.According to the documentation
removed
is added to the object, though typescript says otherwise.https://web3js.readthedocs.io/en/v1.2.11/web3-eth-contract.html#contract-events-return
Steps to Reproduce
Not applicable
Web3.js Version
1.7.0
Environment
No response
Anything Else?
No response
The text was updated successfully, but these errors were encountered: