-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maxFeePerGas
and maxPriorityFeePerGas
have to be given as hex strings
#4210
Closed
Labels
1.x
1.0 related issues
Comments
This was referenced Jul 29, 2021
GregTheGreek
pushed a commit
that referenced
this issue
Jul 31, 2021
16 tasks
spacesailor24
added a commit
that referenced
this issue
Jul 31, 2021
* Closes #4210 - allow non-hex values for eip1559 gas params * Add tests for 4210 * Closes #4211 * Add tests for 4210 (#4218) * Update CHANGELOG Co-authored-by: Greg Markou <[email protected]> Co-authored-by: Wyatt Barnes <[email protected]> Co-authored-by: Wyatt Barnes <[email protected]>
This was referenced Nov 24, 2021
This was referenced Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
It should be possible to give these fields in the same formats that web3 accepts for other numeric fields (numbers, decimal or hexadecimal numeric strings, BNs, BigNumbers).
Actual behavior
You get an error unless they're given as hex strings. See example in logs below.
Steps to reproduce the behavior
Make any transaction with
web3.eth.sendTransaction
with eithermaxFeePerGas
ormaxPriorityFeePerGas
in any format other than a hex string! (E.g. number, decimal numeric string, BN, or BigNumber.)Logs
Example with Truffle console:
Environment
NPM: 6.14.11
Node: 12.21.0
web3.js: 1.5.0
The text was updated successfully, but these errors were encountered: