base.py create_table does not delegate all that it should

[michele-comitini]

There are references to sqlite and mysql specific checks, those checks should be delegated to correct driver. While could be good for perfomance reasons this is very bad for code maintenability, and should be corrected.

see for instance:

https://github.com/web2py/pydal/blob/master/pydal/adapters/base.py#L404
https://github.com/web2py/pydal/blob/master/pydal/adapters/base.py#L433

[gi0baro]

Agree.

[gi0baro]

@michele-comitini can I assign you this?

[michele-comitini]

@gi0baro of course!

[gi0baro]

@michele-comitini would you able to close this for the current milestone (expiring on the 13th) or should we post-pone to the next one?

[michele-comitini]

please postpone! It's not bug critical, but requires some refactoring that
could affect the entire package... so no hurry...

2015-02-09 13:17 GMT+01:00 Giovanni Barillari [email protected]:

@michele-comitini https://github.com/michele-comitini would you able to
close this for the current milestone (expiring on the 13th) or should we
post-pone to the next one?

—
Reply to this email directly or view it on GitHub
#49 (comment).

[gi0baro]

Ok, fine 👍

[gi0baro]

@michele-comitini any news about this?

[michele-comitini]

You have to wait. requires a lot of work and my temptatives break most
adapters still, so I would not push for web2py 2.10.

2015-03-20 13:09 GMT+01:00 Giovanni Barillari [email protected]:

@michele-comitini https://github.com/michele-comitini any news about
this?

—
Reply to this email directly or view it on GitHub
#49 (comment).

[gi0baro]

That's ok, just take your time. I requested a status update only to know if keep it to the "15.04" milestone or move it to the next one.