with smart_query() "in" don't works with ID field type

[BuhtigithuB]

Why?

Is there any considerations (differents backend don't work the same) for this or maybe it is just a forget??

I can do that in PostgreSQL

SELECT id 
   FROM table_name
 WHERE id in (1, 2, 3)

And even with DAL

db(db.table_name.id.belongs([1, 2, 3])).select()

[niphlod]

 table.id in "1,2" 

works wonderfully. What are you seeking for ?

[BuhtigithuB]

Maybe my web2py version then... will see when I get my test_smart_query.py
tests workin...

The above wasn't working in web2py 2.9.5 in ipython shell...

Richard

On Wed, Apr 29, 2015 at 4:27 PM, niphlod [email protected] wrote:

table.id in "1,2"

works wonderfully. What are you seeking for ?

—
Reply to this email directly or view it on GitHub
#161 (comment).

[niphlod]

can I see the traceback from the LATEST stable ?
if yes, please post it.
If not, close this issue right away.

BTW: What's the point of wasting everyone's time chasing a fixed bug on a release more than one year old ?!

[BuhtigithuB]

I just open a ticket to make sure I don't forget it...

I wasn't able to execute my tests case against pydal at that moment...

Will include this test and we will see if pydal is ok or not...

Please review and merge my coming PR rapidly and we can investigate further
this issue...

Richard

On Wed, Apr 29, 2015 at 4:42 PM, niphlod [email protected] wrote:

can I see the traceback from the LATEST stable ?
if yes, please post it.
If not, close this issue right away.

BTW: What's the point of wasting everyone's time chasing a fixed bug on a
release more than one year old ?!

—
Reply to this email directly or view it on GitHub
#161 (comment).

[gi0baro]

The mentioned PR is #162

[BuhtigithuB]

Can be closed #167

[gi0baro]

Let's leave this opened until we don't see #167 passing belongs tests..

[BuhtigithuB]

Locally "in" for ID field pass... I don't know what's going on with Travis
CI... If you can try to uncomment the line and see if test pass in your
environment... Just make sure to change the typo in the test in the merged
version of test_smart_query(). I didn't just uncomment I also repalce a
miss match of field name between (query) and 'text query'...

On Fri, May 1, 2015 at 10:14 AM, Giovanni Barillari <
[email protected]> wrote:

Reopened #161 #161.

—
Reply to this email directly or view it on GitHub
#161 (comment).

[ilvalle]

@BuhtigithuB the list order isn't the same and the build fails. See the output of this job https://travis-ci.org/ilvalle/pydal/jobs/61180165

[BuhtigithuB]

I have look...

On Mon, May 4, 2015 at 2:06 PM, Paolo Valleri [email protected]
wrote:

@BuhtigithuB https://github.com/BuhtigithuB the list order isn't the
same and the build fails. See the output of this job
https://travis-ci.org/ilvalle/pydal/jobs/61180165

—
Reply to this email directly or view it on GitHub
#161 (comment).

[gi0baro]

@ilvalle @BuhtigithuB any update on this?

[BuhtigithuB]

Sorry, I had been submerged by so many changes where I work, I had to stop
developping and didn't have time at home neither... My understanding was
that I touch the order of "in" keyword in my commited "unmodify" version of
the smart_query()... Pablo spotted the error, I didn't check and don't know
if it have been corrected or not... I know Pablo have change the
smart_query test file that I commited so, I guess he does the same with
mistaken wrong ordered version of smar_query().

Richard

On Thu, Jul 2, 2015 at 9:32 AM, Giovanni Barillari <[email protected]

wrote:

@ilvalle https://github.com/ilvalle @BuhtigithuB
https://github.com/BuhtigithuB any update on this?

—
Reply to this email directly or view it on GitHub
#161 (comment).

[BuhtigithuB]

I would check it, but I don't have the last up to date version of my repo
here, I will check it to night...

Richard

On Mon, Jul 6, 2015 at 9:36 AM, Richard Vézina [email protected]
wrote:

Sorry, I had been submerged by so many changes where I work, I had to stop
developping and didn't have time at home neither... My understanding was
that I touch the order of "in" keyword in my commited "unmodify" version of
the smart_query()... Pablo spotted the error, I didn't check and don't know
if it have been corrected or not... I know Pablo have change the
smart_query test file that I commited so, I guess he does the same with
mistaken wrong ordered version of smar_query().

Richard

On Thu, Jul 2, 2015 at 9:32 AM, Giovanni Barillari <
[email protected]> wrote:

@ilvalle https://github.com/ilvalle @BuhtigithuB
https://github.com/BuhtigithuB any update on this?

—
Reply to this email directly or view it on GitHub
#161 (comment).

[BuhtigithuB]

fix mistakes that make in/belongs tests failed #251

Still!!

Locally smart_query tests pass... It seems that it works with some adapter and not with other, there maybe some part of the issue related to the python version... For example postgres2 adapter pass all the way exceptin python 2.6 and 3.4...