Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Рефакторит компонент blob #335

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Рефакторит компонент blob #335

merged 2 commits into from
Sep 25, 2023

Conversation

monochromer
Copy link
Member

Правки:

  • Уменьшает дублирование стилей для задания маски blob с помощью custom properties
  • Переносит задание position: relative с .article-card__avatar на .blob, чтобы это лучше соответствовало принципам БЭМ: элемент .blob__photo имеет абсолютное позиционирование, поэтому position: relative; должно быть на родительском блоке.

@pepelsbey pepelsbey merged commit 006f3e2 into web-standards-ru:main Sep 25, 2023
5 checks passed
@pepelsbey
Copy link
Member

Спасибо!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepelsbey pepelsbey pepelsbey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@monochromer @pepelsbey