[import.meta.url] Implement import.meta.url behind flag (Blink-side) #7888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 18, 2017
Build PASSEDStarted: 2017-10-24 01:34:49 View more information about this build on: |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-726525
branch
2 times, most recently
from
35182ab to
8de7fd3
Compare
5 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-726525
branch
2 times, most recently
from
7942168 to
80b3df6
Compare
This CL implements https://html.spec.whatwg.org/#hostgetimportmetaproperties as HostGetImportMetaProperties() in V8Initializer.cpp and Modulator, and thus enables import.meta.url behind the flag added in https://chromium-review.googlesource.com/c/chromium/src/+/727179. This CL also adds a layout test, and sets up virtual test for that. Bug: 773713 Change-Id: I1d28123f803095535ed9a0208587e1dd873376cb Reviewed-on: https://chromium-review.googlesource.com/726525 Commit-Queue: Hiroshige Hayashizaki <[email protected]> Reviewed-by: Kouhei Ueno <[email protected]> Cr-Commit-Position: refs/heads/master@{#510988}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-726525
branch
from
80b3df6 to
0ad3d11
Compare
servo-wpt-sync
pushed a commit
to servo-wpt-sync/web-platform-tests
that referenced
this pull request
Aug 4, 2023
This change replaces OpenSSL with rustls and also the manually curated CA certs file with webpki-roots (effectively the same thing, but as a crate). Generally speaking the design of the network stack is the same. Changes: - Code around certificate overrides needed to be refactored to work with rustls so the various thread-safe list of certificates is refactored into `CertificateErrorOverrideManager` - hyper-rustls takes care of setting ALPN protocols for HTTP requests, so for WebSockets this is moved to the WebSocket code. - The safe set of cypher suites is chosen, which seem to correspond to the "Modern" configuration from [1]. This can be adjusted later. - Instead of passing a string of PEM CA certificates around, an enum is used that includes parsed Certificates (or the default which reads them from webpki-roots). - Code for starting up an SSL server for testing is cleaned up a little, due to the fact that the certificates need to be overriden explicitly now. This is due to the fact that the `webpki` crate is more stringent with self-signed certificates than SSL (CA certificates cannot used as end-entity certificates). [2] 1. https://wiki.mozilla.org/Security/Server_Side_TLS 2. briansmith/webpki#114 Fixes web-platform-tests#7888. Fixes web-platform-tests#13749. Fixes web-platform-tests#26835. Fixes web-platform-tests#29291.
servo-wpt-sync
pushed a commit
to servo-wpt-sync/web-platform-tests
that referenced
this pull request
Aug 4, 2023
This change replaces OpenSSL with rustls and also the manually curated CA certs file with webpki-roots (effectively the same thing, but as a crate). Generally speaking the design of the network stack is the same. Changes: - Code around certificate overrides needed to be refactored to work with rustls so the various thread-safe list of certificates is refactored into `CertificateErrorOverrideManager` - hyper-rustls takes care of setting ALPN protocols for HTTP requests, so for WebSockets this is moved to the WebSocket code. - The safe set of cypher suites is chosen, which seem to correspond to the "Modern" configuration from [1]. This can be adjusted later. - Instead of passing a string of PEM CA certificates around, an enum is used that includes parsed Certificates (or the default which reads them from webpki-roots). - Code for starting up an SSL server for testing is cleaned up a little, due to the fact that the certificates need to be overriden explicitly now. This is due to the fact that the `webpki` crate is more stringent with self-signed certificates than SSL (CA certificates cannot used as end-entity certificates). [2] 1. https://wiki.mozilla.org/Security/Server_Side_TLS 2. briansmith/webpki#114 Fixes web-platform-tests#7888. Fixes web-platform-tests#13749. Fixes web-platform-tests#26835. Fixes web-platform-tests#29291.
servo-wpt-sync
pushed a commit
to servo-wpt-sync/web-platform-tests
that referenced
this pull request
Aug 7, 2023
This change replaces OpenSSL with rustls and also the manually curated CA certs file with webpki-roots (effectively the same thing, but as a crate). Generally speaking the design of the network stack is the same. Changes: - Code around certificate overrides needed to be refactored to work with rustls so the various thread-safe list of certificates is refactored into `CertificateErrorOverrideManager` - hyper-rustls takes care of setting ALPN protocols for HTTP requests, so for WebSockets this is moved to the WebSocket code. - The safe set of cypher suites is chosen, which seem to correspond to the "Modern" configuration from [1]. This can be adjusted later. - Instead of passing a string of PEM CA certificates around, an enum is used that includes parsed Certificates (or the default which reads them from webpki-roots). - Code for starting up an SSL server for testing is cleaned up a little, due to the fact that the certificates need to be overriden explicitly now. This is due to the fact that the `webpki` crate is more stringent with self-signed certificates than SSL (CA certificates cannot used as end-entity certificates). [2] 1. https://wiki.mozilla.org/Security/Server_Side_TLS 2. briansmith/webpki#114 Fixes web-platform-tests#7888. Fixes web-platform-tests#13749. Fixes web-platform-tests#26835. Fixes web-platform-tests#29291.
servo-wpt-sync
pushed a commit
to servo-wpt-sync/web-platform-tests
that referenced
this pull request
Aug 8, 2023
This change replaces OpenSSL with rustls and also the manually curated CA certs file with webpki-roots (effectively the same thing, but as a crate). Generally speaking the design of the network stack is the same. Changes: - Code around certificate overrides needed to be refactored to work with rustls so the various thread-safe list of certificates is refactored into `CertificateErrorOverrideManager` - hyper-rustls takes care of setting ALPN protocols for HTTP requests, so for WebSockets this is moved to the WebSocket code. - The safe set of cypher suites is chosen, which seem to correspond to the "Modern" configuration from [1]. This can be adjusted later. - Instead of passing a string of PEM CA certificates around, an enum is used that includes parsed Certificates (or the default which reads them from webpki-roots). - Code for starting up an SSL server for testing is cleaned up a little, due to the fact that the certificates need to be overriden explicitly now. This is due to the fact that the `webpki` crate is more stringent with self-signed certificates than SSL (CA certificates cannot used as end-entity certificates). [2] 1. https://wiki.mozilla.org/Security/Server_Side_TLS 2. briansmith/webpki#114 Fixes web-platform-tests#7888. Fixes web-platform-tests#13749. Fixes web-platform-tests#26835. Fixes web-platform-tests#29291.
servo-wpt-sync
pushed a commit
to servo-wpt-sync/web-platform-tests
that referenced
this pull request
Aug 8, 2023
This change replaces OpenSSL with rustls and also the manually curated CA certs file with webpki-roots (effectively the same thing, but as a crate). Generally speaking the design of the network stack is the same. Changes: - Code around certificate overrides needed to be refactored to work with rustls so the various thread-safe list of certificates is refactored into `CertificateErrorOverrideManager` - hyper-rustls takes care of setting ALPN protocols for HTTP requests, so for WebSockets this is moved to the WebSocket code. - The safe set of cypher suites is chosen, which seem to correspond to the "Modern" configuration from [1]. This can be adjusted later. - Instead of passing a string of PEM CA certificates around, an enum is used that includes parsed Certificates (or the default which reads them from webpki-roots). - Code for starting up an SSL server for testing is cleaned up a little, due to the fact that the certificates need to be overriden explicitly now. This is due to the fact that the `webpki` crate is more stringent with self-signed certificates than SSL (CA certificates cannot used as end-entity certificates). [2] 1. https://wiki.mozilla.org/Security/Server_Side_TLS 2. briansmith/webpki#114 Fixes web-platform-tests#7888. Fixes web-platform-tests#13749. Fixes web-platform-tests#26835. Fixes web-platform-tests#29291.
servo-wpt-sync
pushed a commit
that referenced
this pull request
Aug 8, 2023
This change replaces OpenSSL with rustls and also the manually curated CA certs file with webpki-roots (effectively the same thing, but as a crate). Generally speaking the design of the network stack is the same. Changes: - Code around certificate overrides needed to be refactored to work with rustls so the various thread-safe list of certificates is refactored into `CertificateErrorOverrideManager` - hyper-rustls takes care of setting ALPN protocols for HTTP requests, so for WebSockets this is moved to the WebSocket code. - The safe set of cypher suites is chosen, which seem to correspond to the "Modern" configuration from [1]. This can be adjusted later. - Instead of passing a string of PEM CA certificates around, an enum is used that includes parsed Certificates (or the default which reads them from webpki-roots). - Code for starting up an SSL server for testing is cleaned up a little, due to the fact that the certificates need to be overriden explicitly now. This is due to the fact that the `webpki` crate is more stringent with self-signed certificates than SSL (CA certificates cannot used as end-entity certificates). [2] 1. https://wiki.mozilla.org/Security/Server_Side_TLS 2. briansmith/webpki#114 Fixes #7888. Fixes #13749. Fixes #26835. Fixes #29291.
Lightning00Blade
pushed a commit
to Lightning00Blade/wpt
that referenced
this pull request
Dec 11, 2023
This change replaces OpenSSL with rustls and also the manually curated CA certs file with webpki-roots (effectively the same thing, but as a crate). Generally speaking the design of the network stack is the same. Changes: - Code around certificate overrides needed to be refactored to work with rustls so the various thread-safe list of certificates is refactored into `CertificateErrorOverrideManager` - hyper-rustls takes care of setting ALPN protocols for HTTP requests, so for WebSockets this is moved to the WebSocket code. - The safe set of cypher suites is chosen, which seem to correspond to the "Modern" configuration from [1]. This can be adjusted later. - Instead of passing a string of PEM CA certificates around, an enum is used that includes parsed Certificates (or the default which reads them from webpki-roots). - Code for starting up an SSL server for testing is cleaned up a little, due to the fact that the certificates need to be overriden explicitly now. This is due to the fact that the `webpki` crate is more stringent with self-signed certificates than SSL (CA certificates cannot used as end-entity certificates). [2] 1. https://wiki.mozilla.org/Security/Server_Side_TLS 2. briansmith/webpki#114 Fixes web-platform-tests#7888. Fixes web-platform-tests#13749. Fixes web-platform-tests#26835. Fixes web-platform-tests#29291.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL implements
https://html.spec.whatwg.org/#hostgetimportmetaproperties
as HostGetImportMetaProperties() in V8Initializer.cpp and Modulator,
and thus enables import.meta.url behind the flag added in
https://chromium-review.googlesource.com/c/chromium/src/+/727179.
This CL also adds a layout test, and sets up virtual test for that.
Bug: 773713
Change-Id: I1d28123f803095535ed9a0208587e1dd873376cb
Reviewed-on: https://chromium-review.googlesource.com/726525
Commit-Queue: Hiroshige Hayashizaki [email protected]
Reviewed-by: Kouhei Ueno [email protected]
Cr-Commit-Position: refs/heads/master@{#510988}