Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wdspec] fix extension tests for Chrome #51016

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[wdspec] fix extension tests for Chrome #51016

wants to merge 2 commits into from

Conversation

OrKoN
Copy link
Contributor

@OrKoN OrKoN commented Feb 28, 2025 •
edited
Loading

This PR relaxes the ID assertions for unpacked extensions allowing browsers that support dynamic IDs to still pass the tests.

@OrKoN OrKoN force-pushed the orkon/more-chrome-fixes branch 3 times, most recently from 69929e3 to 6aef13e Compare February 28, 2025 08:51
@OrKoN OrKoN force-pushed the orkon/more-chrome-fixes branch from 6aef13e to 92cb2b8 Compare February 28, 2025 11:31
@OrKoN OrKoN enabled auto-merge (squash) February 28, 2025 11:34
@community-tc-integration Community-TC Integration
Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/ZauBgS5KQjS6REIhPfLDog/HUoLc7p7TAu44DrxnS_qeQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/ZauBgS5KQjS6REIhPfLDog"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/ZauBgS5KQjS6REIhPfLDog/HUoLc7p7TAu44DrxnS_qeQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/ZauBgS5KQjS6REIhPfLDog"
      ]
    }
  ]
}
  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-02-28T13:35:57.114Z

@OrKoN OrKoN closed this Feb 28, 2025
auto-merge was automatically disabled February 28, 2025 13:36

Pull request was closed

@OrKoN OrKoN reopened this Feb 28, 2025
whimboo
whimboo reviewed Feb 28, 2025
View reviewed changes
webdriver/tests/bidi/web_extension/install/install.py
Comment on lines +28 to +31
if extension_data["id"] is None:
assert isinstance(web_extension, str)
else:
assert web_extension == extension_data["id"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind creating a helper for it so that it can be shared with all the other tests doing the same assertion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be only used for the unpacked test. We could add a helper once there are more tests like this.

@OrKoN OrKoN closed this Feb 28, 2025
@OrKoN OrKoN reopened this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whimboo whimboo whimboo left review comments

@sadym-chromium sadym-chromium sadym-chromium approved these changes

@AutomatedTester AutomatedTester Awaiting requested review from AutomatedTester

@jgraham jgraham Awaiting requested review from jgraham

@juliandescottes juliandescottes Awaiting requested review from juliandescottes

@shs96c shs96c Awaiting requested review from shs96c

Assignees

@whimboo whimboo

Labels
infra mozilla:gecko-blocked webdriver webdriver-bidi wg-s_browser-tools-testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@OrKoN @whimboo @sadym-chromium @wpt-pr-bot @moz-wptsync-bot