Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wdspec] add user context subscription tests #50434

Merged
merged 2 commits into from
Feb 3, 2025
Merged

[wdspec] add user context subscription tests #50434

merged 2 commits into from
Feb 3, 2025

Conversation

OrKoN
Copy link
Contributor

@OrKoN OrKoN commented Feb 3, 2025 •
edited
Loading

This CL adds tests that verify:

  • subscription to one non-default context
  • subscription to one non-default context and the default context
  • browsing context created event is emitted for existing browsing contexts when subscribing to a user context

@OrKoN OrKoN marked this pull request as ready for review February 3, 2025 10:20
@OrKoN OrKoN mentioned this pull request Feb 3, 2025
Closed
2 tasks
@OrKoN OrKoN force-pushed the orkon/user-context-event-subscriptions branch from 57dbd06 to d8001b7 Compare February 3, 2025 11:36
@OrKoN OrKoN force-pushed the orkon/user-context-event-subscriptions branch from d8001b7 to 7d8c825 Compare February 3, 2025 12:34
juliandescottes
juliandescottes requested changes Feb 3, 2025
View reviewed changes
webdriver/tests/support/fixtures_bidi.py Outdated Show resolved Hide resolved
webdriver/tests/support/fixtures_bidi.py Outdated Show resolved Hide resolved
@OrKoN OrKoN requested a review from juliandescottes February 3, 2025 12:52
juliandescottes
juliandescottes approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@juliandescottes juliandescottes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @OrKoN !
Maybe wait a bit for @lutien 's feedback who spent more time on this.

lutien
lutien approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@lutien lutien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well, thanks!

@OrKoN OrKoN enabled auto-merge (squash) February 3, 2025 13:52
@OrKoN OrKoN merged commit 4587221 into master Feb 3, 2025
12 of 16 checks passed
@OrKoN OrKoN deleted the orkon/user-context-event-subscriptions branch February 3, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliandescottes juliandescottes juliandescottes approved these changes

@lutien lutien lutien approved these changes

@Lightning00Blade Lightning00Blade Lightning00Blade approved these changes

@AutomatedTester AutomatedTester Awaiting requested review from AutomatedTester

@jgraham jgraham Awaiting requested review from jgraham

@sadym-chromium sadym-chromium Awaiting requested review from sadym-chromium

@shs96c shs96c Awaiting requested review from shs96c

@whimboo whimboo Awaiting requested review from whimboo

Assignees

@whimboo whimboo

Labels
webdriver webdriver-bidi wg-s_browser-tools-testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@OrKoN @juliandescottes @lutien @Lightning00Blade @whimboo @wpt-pr-bot