Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-fonts] Add a test that src:local matches a single face, not a whole family. #50051

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

jfkthame
Copy link
Contributor

This was discussed at some length several years ago in #28990, but the test there never got merged.

Given the time that has passed, it seemed cleanest to rewrite this as a new PR that simply adds the test we concluded was missing.

This test depends on having a locally-installed Arial font family, which is true across all current macOS and Windows versions, but may not be the case on other platforms; in that case it falls back to Ahem and should harmlessly "pass" without really testing anything.

…ole family.

This was discussed at some length several years ago in
web-platform-tests#28990,
but the test there never got merged.

Given the time that has passed, it seemed cleanest to rewrite this
as a new PR that simply adds the test we concluded was missing.

This test depends on having a locally-installed Arial font family,
which is true across all current macOS and Windows versions,
but may not be the case on other platforms; in that case it falls back
to Ahem and should harmlessly "pass" without really testing anything.
Copy link
Contributor

@drott drott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfkthame jfkthame merged commit ab57bca into web-platform-tests:master Jan 14, 2025
19 checks passed
@jfkthame jfkthame deleted the font-face-local branch January 14, 2025 10:32
sadym-chromium pushed a commit that referenced this pull request Jan 14, 2025
…ole family. (#50051)

This was discussed at some length several years ago in
#28990,
but the test there never got merged.

Given the time that has passed, it seemed cleanest to rewrite this
as a new PR that simply adds the test we concluded was missing.

This test depends on having a locally-installed Arial font family,
which is true across all current macOS and Windows versions,
but may not be the case on other platforms; in that case it falls back
to Ahem and should harmlessly "pass" without really testing anything.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants