[wdspec] add context locator tests involving iframes and shadow DOM #50047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/context-locator-invalid
branch
2 times, most recently
from
785d8ac to
abb3ddb
Compare
wpt-pr-bot
requested review from
AutomatedTester,
jgraham,
juliandescottes,
sadym-chromium,
shs96c and
whimboo
OrKoN
changed the title
whimboo
previously requested changes
Jan 13, 2025
sadym-chromium
approved these changes
Jan 14, 2025
|
@whimboo do you still have concerns? |
sadym-chromium
force-pushed
the
orkon/context-locator-invalid
branch
from
95dc2fd to
17868f6
Compare
Sorry, I missed to actually hit the send button. Nevertheless it's merged now and we will check for completeness when implementing this locator in Firefox. Thanks for both of your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.