Add leading/trailing whitespace subtests #49537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AmeliaBR,
annevk,
domenic,
foolip,
fserb,
jdm,
jgraham and
kenrussell
annevk
requested changes
Dec 5, 2024
| @@ -52,6 +58,7 @@ <h1>2d.text.measure.actualBoundingBox</h1> | |||
| _assert(ctx.measureText('D').actualBoundingBoxDescent >= 12, "ctx.measureText('D').actualBoundingBoxDescent >= 12"); | |||
| _assert(ctx.measureText('D').actualBoundingBoxDescent <= 15, "ctx.measureText('D').actualBoundingBoxDescent <= 15"); | |||
|
|
|||
|
|
|||
| _assert(ctx.measureText('A ').actualBoundingBoxRight >= 50, "ctx.measureText('A ').actualBoundingBoxRight >= 50"); | ||
|
|
||
| _assert(Math.abs(ctx.measureText(' A').actualBoundingBoxLeft) >= 50, "Math.abs(ctx.measureText(' A').actualBoundingBoxLeft) >= 50"); | ||
| _assert(ctx.measureText(' A').actualBoundingBoxRight <= 101, "ctx.measureText(' A').actualBoundingBoxRight <= 101"); |
There was a problem hiding this comment.
It might be useful to separate this out so it can be tested standalone. I think we also want to test some other whitespace code points. Unicode has a lot of them.
Oops still not enough CAPS for me clearly :) Will fix. |
Add leading/trailing whitespace subtests to verify the effects on actualBoundingBoxLeft/actualBoundingBoxRight text metrics.
rwlbuis
force-pushed
the
add_leading_trsiling_whitespace_subtests
branch
from
f8c2bae to
995fe84
Compare
annevk
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
This looks like a good start, but I would really recommend adding tests for more types of whitespace to ensure implementations are aligned on what whitespace gets ignored. See https://en.wikipedia.org/wiki/Whitespace_character for inspiration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add leading/trailing whitespace subtests to verify the effects on actualBoundingBoxLeft/actualBoundingBoxRight text metrics.