Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Initial Web Platform Tests for Storage Access Headers #49502

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

This change adds web platform tests that confirm the inclusion of the
Sec-Fetch-Storage-Access header on cross-site navigations, and that confirm the browser properly handles responses which include the Activate-Storage-Access header.

Bug: 332335089
Change-Id: If453daea7b77292a6498f22b86a552a5a064b521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5972601
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Chris Fredrickson <[email protected]>
Commit-Queue: Sam LeDoux <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1391183}

This change adds web platform tests that confirm the inclusion of the
`Sec-Fetch-Storage-Access` header on cross-site navigations, and that confirm the browser properly handles responses which include the `Activate-Storage-Access` header.

Bug: 332335089
Change-Id: If453daea7b77292a6498f22b86a552a5a064b521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5972601
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Chris Fredrickson <[email protected]>
Commit-Queue: Sam LeDoux <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1391183}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@WeizhongX
Copy link
Contributor

Safari run failed due to:

ERROR WebDriver was not accessible within 30 seconds.
ERROR Traceback (most recent call last):
File "/Users/runner/work/1/s/tools/wptrunner/wptrunner/browsers/base.py", line 373, in _run_server
wait_for_service(
File "/Users/runner/work/1/s/tools/wptrunner/wptrunner/environment.py", line 374, in wait_for_service
raise OSError("Service is unavailable: %s:%i" % addr)
OSError: Service is unavailable: 127.0.0.1:49361

ERROR Failure during init:
Traceback (most recent call last):
File "/Users/runner/work/1/s/tools/wptrunner/wptrunner/testrunner.py", line 261, in init
self.browser.start(group_metadata=group_metadata, **self.browser_settings)
File "/Users/runner/work/1/s/tools/wptrunner/wptrunner/browsers/base.py", line 339, in start
self._run_server(group_metadata, **kwargs)
File "/Users/runner/work/1/s/tools/wptrunner/wptrunner/browsers/base.py", line 373, in _run_server
wait_for_service(
File "/Users/runner/work/1/s/tools/wptrunner/wptrunner/environment.py", line 374, in wait_for_service
raise OSError("Service is unavailable: %s:%i" % addr)
OSError: Service is unavailable: 127.0.0.1:49361

@WeizhongX
Copy link
Contributor

WPT Command: python3 ./wpt run --channel=nightly --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full --binary=/home/test/build/firefox/firefox firefox

Some affected tests had inconsistent (flaky) results:

Unstable results

Test | Subtest | Results | Messages -- | -- | -- | --

/storage-access-api/hasStorageAccess-insecure.sub.window.html |   | OK: 9/10, TIMEOUT: 1/10 |  
/storage-access-api/requestStorageAccess-insecure.sub.window.html |   | OK: 8/10, TIMEOUT: 2/10 |  
/storage-access-api/requestStorageAccess-insecure.sub.window.html | [top-level-context] document.requestStorageAccess() should be rejected when called with a user gesture in insecure context | PASS: 8/10, TIMEOUT: 2/10 | Test timed out
/storage-access-api/storage-access-permission.sub.https.window.html | Permissions grants are observable across same-origin iframes | FAIL: 1/10, PASS: 9/10 | assert_equals: expected (string) "granted" but got (object) object "[object Object]"

These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag @web-platform-tests/wpt-core-team in a comment for help.

@WeizhongX WeizhongX closed this Dec 10, 2024
@WeizhongX WeizhongX reopened this Dec 10, 2024
@WeizhongX
Copy link
Contributor

Created https://buganizer.corp.google.com/issues/383343224.

@DanielRyanSmith @jcscottiii can you help admin merge?

@jcscottiii jcscottiii merged commit 6a03539 into master Dec 10, 2024
20 of 22 checks passed
@jcscottiii jcscottiii deleted the chromium-export-5bb5f07e46 branch December 10, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants