-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Initial Web Platform Tests for Storage Access Headers #49502
Conversation
This change adds web platform tests that confirm the inclusion of the `Sec-Fetch-Storage-Access` header on cross-site navigations, and that confirm the browser properly handles responses which include the `Activate-Storage-Access` header. Bug: 332335089 Change-Id: If453daea7b77292a6498f22b86a552a5a064b521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5972601 Reviewed-by: Avi Drissman <[email protected]> Reviewed-by: Chris Fredrickson <[email protected]> Commit-Queue: Sam LeDoux <[email protected]> Cr-Commit-Position: refs/heads/main@{#1391183}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
Safari run failed due to: ERROR WebDriver was not accessible within 30 seconds. ERROR Failure during init: |
WPT Command: Some affected tests had inconsistent (flaky) results: Unstable resultsTest | Subtest | Results | Messages -- | -- | -- | --/storage-access-api/hasStorageAccess-insecure.sub.window.html | | OK: 9/10, TIMEOUT: 1/10 | These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag |
Created https://buganizer.corp.google.com/issues/383343224. @DanielRyanSmith @jcscottiii can you help admin merge? |
This change adds web platform tests that confirm the inclusion of the
Sec-Fetch-Storage-Access
header on cross-site navigations, and that confirm the browser properly handles responses which include theActivate-Storage-Access
header.Bug: 332335089
Change-Id: If453daea7b77292a6498f22b86a552a5a064b521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5972601
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Chris Fredrickson <[email protected]>
Commit-Queue: Sam LeDoux <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1391183}