Improve Trusted Types test coverage over eval and Function constructor #49461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewarlow
force-pushed
the
trusted-types-eval-Function-extensive
branch
from
c202501 to
b37b2fd
Compare
fred-wang
approved these changes
Dec 2, 2024
content-security-policy/reporting/report-clips-sample.https.html
Outdated
Show resolved
Hide resolved
content-security-policy/reporting/report-clips-sample.https.html
Outdated
Show resolved
Hide resolved
- Add tests for multi-argument function constructor calls - Add tests for exotic Function types (e.g. generators) - Add more tests for the CSP sample prefix-stripping behaviour - Fixed default policy sample test for Function constructor to match spec. (Chromium is non-spec compliant currently).
lukewarlow
force-pushed
the
trusted-types-eval-Function-extensive
branch
from
b37b2fd to
44fd27b
Compare
fred-wang
reviewed
Dec 6, 2024
| }, `Unsafe indirect eval violation sample is clipped to ${trimmedSampleLength} characters.`); | ||
|
|
||
| const functionBody = "return '1234567890123456789012345678901234567890';"; | ||
| const sampleWithoutFunctionPrefix = `(a,b\n) {\nreturn ${functionBody}\n}`; |
There was a problem hiding this comment.
@lukewarlow I hadn't checked the change again after approving, but sampleWithoutFunctionPrefix should not have the return statement, since it's already in functionBody.
There was a problem hiding this comment.
Apologies I should have spotted that! (None of the browsers currently pass this test so didn't actually run it to double check).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for multi-argument function constructor calls
Add tests for exotic Function types (e.g. generators)
Add more tests for the CSP sample prefix-stripping behaviour
Fixed default policy sample test for Function constructor to match spec. (Chromium is non-spec compliant currently).