Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speculativly test :has-slotted() #47587

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Speculativly test :has-slotted() #47587

merged 4 commits into from
Sep 23, 2024

Conversation

Westbrook
Copy link
Contributor

As per w3c/csswg-drafts#10586 :has-slotted() is coming!

This adds parsing tests as well as some red/green tests for actual delivery of the selectors in practice.

@Westbrook
Copy link
Contributor Author

cc: @michaelwarren1106 @JRJurman @thescientist13 @keithamus

keithamus
keithamus approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like good tests to get started with an implementation to me, so it gets my approval, but I'll let one of the spec editors decide if there's anything more we need to do here before merging.

@Westbrook
Copy link
Contributor Author

@tabatkins I've got a couple of additional tests for this feature after watching @keithamus work through some WebKit implementation on this feature, would it be better to add them to this PR while it's open or to get this merged in and open a new one?

@Westbrook
Copy link
Contributor Author

@tabatkins let me know if there is anything else I can do here, or in related issues, to support moving this forward. Web Components developers the community over really look forward to a future where these tests are green x-browser.

@Westbrook
Copy link
Contributor Author

If anyone was interested, I have some follow up tests that build on this in Westbrook#1. I've not added them here in hopes of getting a rough "you're not breaking anything" on these tests first. If it's preferred, I can merge the related PR and the changes will flow right into this one, further proving out the :has-slotted and :has-slotted(...) APIs. 🤞🏼

@Westbrook
Merge pull request #1 from Westbrook/has-slotted-expanded
e1e16ca 
Speculatively test :has-slotted() flattened through multiple slot elements
keithamus
keithamus approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@keithamus keithamus merged commit 43f3ba0 into web-platform-tests:master Sep 23, 2024
19 checks passed
@Westbrook Westbrook deleted the has-slotted branch September 23, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

@fantasai fantasai Awaiting requested review from fantasai

@frivoal frivoal Awaiting requested review from frivoal

@kojiishi kojiishi Awaiting requested review from kojiishi

@plinss plinss Awaiting requested review from plinss

@rniwa rniwa Awaiting requested review from rniwa

@tabatkins tabatkins Awaiting requested review from tabatkins

Assignees

@tabatkins tabatkins

Labels
css-scoping selectors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Westbrook @keithamus @tabatkins @wpt-pr-bot @moz-wptsync-bot