-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add name from content tests for CSS text-transform:full-size-kana #47535
Add name from content tests for CSS text-transform:full-size-kana #47535
Conversation
Hi @cookiecrook, I saw that there was already a distinct I created 2 subtests for this PR. The first subtest is a straightforward The second subtest is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
editorial clarity suggestions. thanks.
<h1>heading which visually transforms <span lang="ja">びょういん</span> (hospital) to <span lang="ja">びよういん</span> (beauty parlor) using CSS <code>text-transform:full-size-kana</code></h1> | ||
<h3 lang="ja" data-expectedlabel="びょういん" data-testname="heading name from content with text-transform:full-size-kana" class="ex" style="text-transform:full-size-kana;">びょういん</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the second example is more clear why this would happen. Ruby text can be small, so presenting it larger makes it more readable, even though a reader needs to mentally re-convert the text to understand the appropriate meaning.
However, in this first example, why would this ever be used in a heading? Should this subtest also be embedded in an <rt>
element for clarity?
Also, these tests are missing sufficient sentence context, so there is no unambiguous "right" answer. Are you able to add enough that any future editors or reviewers of these tests know that the meaning should be "hospital" (not "beauty parlor") and "dragon" (not "reason").
… via button element
Thanks, @cookiecrook. I’ve added sentence context for both subtests:
I also updated the second subtest to enclose the I’m still waiting for all the results to come through, but it’s notable in Safari that the accname of the button ignores the |
Yes, I would do it the way you did it.
I also initially thought that would be a good test, but a) it's not a name-able element as you've discovered, and b) ruby is ambiguous wrt to labels, so perhaps these subtests should use something simple like a link or a button. (Note: there are ongoing fixes for the duplicative ruby speech, despite the ambiguity in the spec. Best to avoid those in compartmentalized automation tests in the meantime.) |
<h3 lang="ja" data-expectedlabel="びょういんのかんじゃサービス" data-testname="heading name from content with text-transform:full-size-kana" class="ex" style="text-transform:full-size-kana;">びょういんのかんじゃサービス</h3> | ||
|
||
<!-- “竜の背に乗る” means “Ride the dragon’s back” --> | ||
<!-- text-transform:full-size-kana incorrectly changes 竜’s <rt> furigana: --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"incorrectly" may be confusing... As it's the correct behavior for rendered text, but should not be transformed in the test exposed to the Accessibility APIs… Note: I expect implementors may have questions about how to achieve this, so it's good this is in a tentative file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here’s another cut at that. I also went ahead and commented out the second subtest.
Co-authored-by: James Craig <[email protected]>
Co-authored-by: James Craig <[email protected]>
Co-authored-by: James Craig <[email protected]>
Closes web-platform-tests/interop-accessibility#137.