Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Selection API] Change getComposedRanges() from rest parameter to a dictionary #47523

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Aug 8, 2024

Per w3c/selection-api#176, we should update
selection.getComposedRanges() from using a rest shadowRoots parameter
to using a dictionary that contains the array shadowRoots.

Change-Id: I6b5b3fed786cf6d75fa4a20c0b2a583635cd2aca
Bug: 40286116
Fixed: 355577223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5770701
Commit-Queue: Di Zhang <[email protected]>
Reviewed-by: Siye Liu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1338832}

…ictionary

Per w3c/selection-api#176, we should update
selection.getComposedRanges() from using a rest `shadowRoots` parameter
to using a dictionary that contains the array `shadowRoots`.

Change-Id: I6b5b3fed786cf6d75fa4a20c0b2a583635cd2aca
Bug: 40286116
Fixed: 355577223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5770701
Commit-Queue: Di Zhang <[email protected]>
Reviewed-by: Siye Liu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1338832}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 57e2040 into master Aug 8, 2024
21 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-5770701 branch August 8, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants