Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cred Man: add basic get tests #47268

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Cred Man: add basic get tests #47268

merged 1 commit into from
Jul 29, 2024

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Jul 24, 2024 •
edited
Loading

@wpt-pr-bot wpt-pr-bot requested a review from mikewest July 24, 2024 04:53
@marcoscaceres marcoscaceres mentioned this pull request Jul 24, 2024
Merged
4 tasks
@marcoscaceres marcoscaceres requested a review from nsatragno July 24, 2024 04:53
nsatragno
nsatragno approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@nsatragno nsatragno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a comment.

credential-management/credentialscontainer-get-basics.https.html Show resolved Hide resolved
@marcoscaceres marcoscaceres enabled auto-merge (squash) July 26, 2024 06:12
nsatragno
nsatragno approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@nsatragno nsatragno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thank you!

Can't land yet due to the trailing whitespace (check the linter), but you should be good after that.

@marcoscaceres marcoscaceres force-pushed the credentialscontainer-get-basic branch from 800f29e to 417f013 Compare July 29, 2024 02:43
@marcoscaceres marcoscaceres merged commit 8f374a1 into master Jul 29, 2024
17 checks passed
@marcoscaceres marcoscaceres deleted the credentialscontainer-get-basic branch July 29, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsatragno nsatragno nsatragno approved these changes

@mikewest mikewest Awaiting requested review from mikewest

Assignees

@mikewest mikewest

Labels
credential-management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marcoscaceres @nsatragno @mikewest @wpt-pr-bot @moz-wptsync-bot