Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the output of ./wpt make-hosts-file deterministic #47159

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Make the output of ./wpt make-hosts-file deterministic #47159

merged 1 commit into from
Jul 16, 2024

Conversation

gsnedders
Copy link
Member

Previously, the ordering depended on set enumeration order, which is undefined. Instead, we sort based on labels, starting with the TLD.

This makes the output:

127.0.0.1	not-web-platform.test
127.0.0.1	www.not-web-platform.test
127.0.0.1	www.www.not-web-platform.test
127.0.0.1	www1.www.not-web-platform.test
127.0.0.1	www2.www.not-web-platform.test
127.0.0.1	xn--lve-6lad.www.not-web-platform.test
127.0.0.1	xn--n8j6ds53lwwkrqhv28a.www.not-web-platform.test
127.0.0.1	www1.not-web-platform.test
127.0.0.1	www.www1.not-web-platform.test
127.0.0.1	www1.www1.not-web-platform.test
127.0.0.1	www2.www1.not-web-platform.test
127.0.0.1	xn--lve-6lad.www1.not-web-platform.test
127.0.0.1	xn--n8j6ds53lwwkrqhv28a.www1.not-web-platform.test
127.0.0.1	www2.not-web-platform.test
127.0.0.1	www.www2.not-web-platform.test
127.0.0.1	www1.www2.not-web-platform.test
127.0.0.1	www2.www2.not-web-platform.test
127.0.0.1	xn--lve-6lad.www2.not-web-platform.test
127.0.0.1	xn--n8j6ds53lwwkrqhv28a.www2.not-web-platform.test
127.0.0.1	xn--lve-6lad.not-web-platform.test
127.0.0.1	www.xn--lve-6lad.not-web-platform.test
127.0.0.1	www1.xn--lve-6lad.not-web-platform.test
127.0.0.1	www2.xn--lve-6lad.not-web-platform.test
127.0.0.1	xn--lve-6lad.xn--lve-6lad.not-web-platform.test
127.0.0.1	xn--n8j6ds53lwwkrqhv28a.xn--lve-6lad.not-web-platform.test
127.0.0.1	xn--n8j6ds53lwwkrqhv28a.not-web-platform.test
127.0.0.1	www.xn--n8j6ds53lwwkrqhv28a.not-web-platform.test
127.0.0.1	www1.xn--n8j6ds53lwwkrqhv28a.not-web-platform.test
127.0.0.1	www2.xn--n8j6ds53lwwkrqhv28a.not-web-platform.test
127.0.0.1	xn--lve-6lad.xn--n8j6ds53lwwkrqhv28a.not-web-platform.test
127.0.0.1	xn--n8j6ds53lwwkrqhv28a.xn--n8j6ds53lwwkrqhv28a.not-web-platform.test
127.0.0.1	web-platform.test
127.0.0.1	www.web-platform.test
127.0.0.1	www.www.web-platform.test
127.0.0.1	www1.www.web-platform.test
127.0.0.1	www2.www.web-platform.test
127.0.0.1	xn--lve-6lad.www.web-platform.test
127.0.0.1	xn--n8j6ds53lwwkrqhv28a.www.web-platform.test
127.0.0.1	www1.web-platform.test
127.0.0.1	www.www1.web-platform.test
127.0.0.1	www1.www1.web-platform.test
127.0.0.1	www2.www1.web-platform.test
127.0.0.1	xn--lve-6lad.www1.web-platform.test
127.0.0.1	xn--n8j6ds53lwwkrqhv28a.www1.web-platform.test
127.0.0.1	www2.web-platform.test
127.0.0.1	www.www2.web-platform.test
127.0.0.1	www1.www2.web-platform.test
127.0.0.1	www2.www2.web-platform.test
127.0.0.1	xn--lve-6lad.www2.web-platform.test
127.0.0.1	xn--n8j6ds53lwwkrqhv28a.www2.web-platform.test
127.0.0.1	xn--lve-6lad.web-platform.test
127.0.0.1	www.xn--lve-6lad.web-platform.test
127.0.0.1	www1.xn--lve-6lad.web-platform.test
127.0.0.1	www2.xn--lve-6lad.web-platform.test
127.0.0.1	xn--lve-6lad.xn--lve-6lad.web-platform.test
127.0.0.1	xn--n8j6ds53lwwkrqhv28a.xn--lve-6lad.web-platform.test
127.0.0.1	xn--n8j6ds53lwwkrqhv28a.web-platform.test
127.0.0.1	www.xn--n8j6ds53lwwkrqhv28a.web-platform.test
127.0.0.1	www1.xn--n8j6ds53lwwkrqhv28a.web-platform.test
127.0.0.1	www2.xn--n8j6ds53lwwkrqhv28a.web-platform.test
127.0.0.1	xn--lve-6lad.xn--n8j6ds53lwwkrqhv28a.web-platform.test
127.0.0.1	xn--n8j6ds53lwwkrqhv28a.xn--n8j6ds53lwwkrqhv28a.web-platform.test

@gsnedders
Make the output of ./wpt make-hosts-file deterministic
e791712 
Previously, the ordering depended on set enumeration order, which is
undefined. Instead, we sort based on labels, starting with the TLD.
@gsnedders gsnedders enabled auto-merge (rebase) July 16, 2024 18:34
@gsnedders gsnedders merged commit ad94cb8 into web-platform-tests:master Jul 16, 2024
32 of 34 checks passed
@gsnedders gsnedders deleted the make-hosts-file-deterministic branch July 16, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

@jgraham jgraham jgraham approved these changes

@DanielRyanSmith DanielRyanSmith Awaiting requested review from DanielRyanSmith

Assignees

@jgraham jgraham

Labels
infra serve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gsnedders @jgraham @foolip @wpt-pr-bot