Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FedCM] Send SameSite=Lax cookies, in addition to None #47065

Merged
merged 1 commit into from
Jul 10, 2024
Merged

[FedCM] Send SameSite=Lax cookies, in addition to None #47065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions fedcm/support/accounts_check_same_site_strict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ def main(request, response):
return request_error
if request.cookies.get(b"same_site_strict") == b"1":
return (546, [], "Should not send SameSite=Strict cookies")
# TODO(crbug.com/350944661): We want to send these cookies.
if request.cookies.get(b"same_site_lax") == b"1":
return (547, [], "Should not send SameSite=Lax cookies")
if request.headers.get(b"Sec-Fetch-Site") != b"cross-site":
Expand Down
1 change: 1 addition & 0 deletions fedcm/support/token_check_same_site_strict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ def main(request, response):
return request_error
if request.cookies.get(b"same_site_strict") == b"1":
return (546, [], "Should not send SameSite=Strict cookies")
# TODO(crbug.com/350944661): We want to send these cookies.
if request.cookies.get(b"same_site_lax") == b"1":
return (547, [], "Should not send SameSite=Lax cookies")

Expand Down