Create dir-role.tentative.html #45553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add test for the `dir` element, which is defined as obsolete in HTML, but that it should be treated the same as `ul` - and thus be exposed with an implicit role=list
scottaohara
commented
Apr 4, 2024
cookiecrook
reviewed
May 15, 2024
cookiecrook
reviewed
May 15, 2024
There was a problem hiding this comment.
Ideally this PR would also have a line comment for dir (before div) in /html-aam/roles.html pointing to this file.
|
pointing to this file with the .tentative in the name or without? and if it was tentative would then the expectation be to make another PR to change that when this did get accepted and merged? or would this file get deleted and the test added to the other? |
|
Yes. Once there are two implementations of the mapping, I’d expect the |
scottaohara
commented
Aug 19, 2024
cookiecrook
reviewed
Aug 20, 2024
cookiecrook
approved these changes
Aug 20, 2024
|
I hate it when a UI button changes its function during a |
Westbrook
pushed a commit
to Westbrook/wpt
that referenced
this pull request
Aug 21, 2024
add test for the `dir` element, which is defined as obsolete in HTML, but that it should be treated the same as `ul` and thus be exposed with an implicit role=list
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 5, 2024
The dir element is defined as obsolete in HTML and should be exposed as the list role. [1] web-platform-tests/wpt#45553 Fixed: 361126130 Change-Id: Ia1e6cb5be7fa20a69b7a1b421a60d6cae0e154c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5837082 Reviewed-by: Aaron Leventhal <[email protected]> Commit-Queue: Aaron Leventhal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1351373}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add test for the
direlement, which is defined as obsolete in HTML, but that it should be treated the same asul- and thus be exposed with an implicit role=list