-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for DOMStringList #4534
Add tests for DOMStringList #4534
Conversation
Notifying @Ms2ger, @ayg, @gsnedders, @jdm, @jgraham, @sideshowbarker, @zcorpan, and @zqzhang. (Learn how reviewing works.) |
idlArray.add_idls(idls); | ||
|
||
idlArray.add_objects({ | ||
DOMStringList: [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 'location.ancestorOrigins' here?
w3c-test:mirror |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % 1 comment
….] to enable worker tests
Also added the missing |
For #4522 to unblock whatwg/html#2192
Not the most extensive test suite in the world and the dependency on IndexedDB is unfortunate, but it was handy.
Should the idlharness test remain stand-alone or be merged into
html/dom/interfaces.html
?