-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a few missing post-insertion-step tests #44906
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! LGTM % one optional naming nit
@@ -0,0 +1,22 @@ | |||
<!doctype html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically these aren't using appendChild
anymore I guess heh. Idk if we want to update the name of the test files or not, up to you. Just wanted to point that out since it feels a little redundant and is technically not accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
…to Node-append-form-and-script-from-fragment.tentative.html
…ive.html to Node-append-meta-referrer-and-script-from-fragment.tentative.html
* Add insertion step for meta with referrer+script * Added form association test * Rename Node-appendChild-form-and-script-from-fragment.tentative.html to Node-append-form-and-script-from-fragment.tentative.html * Rename Node-appendChild-meta-referrer-and-script-from-fragment.tentative.html to Node-append-meta-referrer-and-script-from-fragment.tentative.html
<meta name=referrer>
is applied