[wptrunner] Plumb expectations wpttest.{Test -> (Subtest)Result}
#44424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows vendors to override expectations at runtime via
browser-specific result converters. Instead of constructing
`(Subtest)Result`s directly, executors should use the newly introduced
`Test.make_{subtest_,}result()`, which have the same signatures but
default to passing through the testloader-read expectations.
This is a pure refactor; no functional changes intended.
Successor to: web-platform-tests#44134 (comment)
jonathan-j-lee
force-pushed
the
wptrunner/plumb-exp
branch
from
cbb0908 to
0f0867b
Compare
wpt-pr-bot
added
infra
wptrunner
WeizhongX
approved these changes
Feb 6, 2024
mbrodesser-Igalia
pushed a commit
to mbrodesser-Igalia/wpt
that referenced
this pull request
Feb 19, 2024
…eb-platform-tests#44424) This allows vendors to override expectations at runtime via browser-specific result converters. Instead of constructing `(Subtest)Result`s directly, executors should use the newly introduced `Test.make_{subtest_,}result()`, which have the same signatures but default to passing through the testloader-read expectations. This is a pure refactor; no functional changes intended. Successor to: web-platform-tests#44134 (comment)
marcoscaceres
pushed a commit
that referenced
this pull request
Feb 23, 2024
…44424) This allows vendors to override expectations at runtime via browser-specific result converters. Instead of constructing `(Subtest)Result`s directly, executors should use the newly introduced `Test.make_{subtest_,}result()`, which have the same signatures but default to passing through the testloader-read expectations. This is a pure refactor; no functional changes intended. Successor to: #44134 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows vendors to override expectations at runtime via
browser-specific result converters. Instead of constructing
(Subtest)Results directly, executors should use the newly introducedTest.make_{subtest_,}result(), which have the same signatures butdefault to passing through the testloader-read expectations.
This is a pure refactor; no functional changes intended.
Successor to: #44134 (comment)