Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use new headless mode for Chrome #44304

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

WeizhongX
Copy link
Contributor

We are going to use headful mode in Chromium, and results for wpt.fyi also comes from headful mode, thus there is no need to run tests in the old headless mode.

crbug.com/753118 is also fixed now. Remove the special handling for print-ref tests also.

We are going to use headful mode in Chromium, and results for wpt.fyi
also comes from headful mode, thus there is no need to run tests in
the old headless mode.

crbug.com/753118 is also fixed now. Remove the special handling for
print-ref tests also.
@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run labels Jan 31, 2024
@WeizhongX
Copy link
Contributor Author

Hey @past, are we using the old headless mode anyway at upstream? Per our experience in chromium, looks like we should never use the old headless mode.

With this change, if we are using the old headless mode, it will be switched to the new headless mode. This should mostly be OK but running in the new headless mode could be 2x slower than the old headless mode.

@WeizhongX
Copy link
Contributor Author

Confirmed with kvitekp@ that Page.printToPDF is fully supported in both old and new headless mode as well as in headful mode.

@kvitekp
Copy link

kvitekp commented Jan 31, 2024

Page.printToPDF is fully supported in both old and new headless mode as well as in headful mode. This includes normal and OOPIF printing.

@kvitekp
Copy link

kvitekp commented Jan 31, 2024

Please be advised that new headless mode is slower than the old one. The reason for that that in new headless mode it is the actual full fledged Chrome browser running with all its functionality but no visble UI whereas in old headless mode we used a thin wrapper around //content layer which is not a real Chrome, so it's faster but lacks all the functionality implemented in or via //chrome.

Copy link
Contributor

@jonathan-j-lee jonathan-j-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since TC uses wpt run --no-headless

@WeizhongX WeizhongX merged commit 231f825 into master Jan 31, 2024
33 checks passed
@WeizhongX WeizhongX deleted the do-not-use-old-headless-mode branch January 31, 2024 18:05
mbrodesser-Igalia pushed a commit to mbrodesser-Igalia/wpt that referenced this pull request Feb 19, 2024
* Only use new headless mode for Chrome

We are going to use headful mode in Chromium, and results for wpt.fyi
also comes from headful mode, thus there is no need to run tests in
the old headless mode.

crbug.com/753118 is also fixed now. Remove the special handling for
print-ref tests also.
marcoscaceres pushed a commit that referenced this pull request Feb 23, 2024
* Only use new headless mode for Chrome

We are going to use headful mode in Chromium, and results for wpt.fyi
also comes from headful mode, thus there is no need to run tests in
the old headless mode.

crbug.com/753118 is also fixed now. Remove the special handling for
print-ref tests also.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants