-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only use new headless mode for Chrome #44304
Conversation
We are going to use headful mode in Chromium, and results for wpt.fyi also comes from headful mode, thus there is no need to run tests in the old headless mode. crbug.com/753118 is also fixed now. Remove the special handling for print-ref tests also.
Hey @past, are we using the old headless mode anyway at upstream? Per our experience in chromium, looks like we should never use the old headless mode. With this change, if we are using the old headless mode, it will be switched to the new headless mode. This should mostly be OK but running in the new headless mode could be 2x slower than the old headless mode. |
Confirmed with kvitekp@ that Page.printToPDF is fully supported in both old and new headless mode as well as in headful mode. |
Page.printToPDF is fully supported in both old and new headless mode as well as in headful mode. This includes normal and OOPIF printing. |
Please be advised that new headless mode is slower than the old one. The reason for that that in new headless mode it is the actual full fledged Chrome browser running with all its functionality but no visble UI whereas in old headless mode we used a thin wrapper around //content layer which is not a real Chrome, so it's faster but lacks all the functionality implemented in or via //chrome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM since TC uses wpt run --no-headless
* Only use new headless mode for Chrome We are going to use headful mode in Chromium, and results for wpt.fyi also comes from headful mode, thus there is no need to run tests in the old headless mode. crbug.com/753118 is also fixed now. Remove the special handling for print-ref tests also.
* Only use new headless mode for Chrome We are going to use headful mode in Chromium, and results for wpt.fyi also comes from headful mode, thus there is no need to run tests in the old headless mode. crbug.com/753118 is also fixed now. Remove the special handling for print-ref tests also.
We are going to use headful mode in Chromium, and results for wpt.fyi also comes from headful mode, thus there is no need to run tests in the old headless mode.
crbug.com/753118 is also fixed now. Remove the special handling for print-ref tests also.