clean up irrelevant ReadMe (re: manual tests) and change reviewer suggestion ahead of automated test PRs #43195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gestion ahead of automated test PRs
cookiecrook
requested review from
adampage,
jnurthen and
rahimabdi
and removed request for
halindrome
cookiecrook
commented
Nov 16, 2023
| @@ -1,3 +1,3 @@ | |||
| spec: https://w3c.github.io/svg-aam/ | |||
| suggested_reviewers: | |||
| - halindrome | |||
| - cookiecrook | |||
There was a problem hiding this comment.
Notes for Reviewers:
- Shane is no longer actively involved in this project,
- The to-be-deleted readme is related to the deprecated "ATTA" tests that were:
a) never written for SVG-AAM
b) require running manually, and
c) not planned for SVG-AAM since we now have the ability to run these as automated tests.
There was a problem hiding this comment.
@cookiecrook My only concern: should there be a second reviewer for backup/greater coverage, and who can delegate if you're unavailable?
(Someone important, not me 😛)
There was a problem hiding this comment.
Any reviewers can be assigned... This is just the auto-assignment feature. But since it sounds like you're volunteering, you're welcome to commit your time on it. 😉
rahimabdi
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for PRs coming related to web-platform-tests/interop-accessibility#69