view-transition: Move pagereveal tests to WPT #42669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 20, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4956092
branch
4 times, most recently
from
9f842aa to
a40a6f7
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4956092
branch
2 times, most recently
from
cb9f629 to
fb3a239
Compare
The `pagereveal` event will be specified and shipped separately from view transitions so move tests into WPT. Since the spec is still WIP these tests are marked tentative for now. Tests that were specifically dealing with usage of the `viewTransition` attribute and its behavior in relation to a view transition were left in the wpt_internal directory for view-transitions since those seems specific to that feature. Review note: PS#1 moves the files, diff from it to see changes. These tests need to run in the no-forced-frame-update virtual test suite since they're testing event order before rendering begins. WPT tests run in single-threaded-mode which does not prevent scheduling frames before rendering begins. This suite was added for other similar tests. Additionally, there is a race during prerender activation between a SynchronousComposite being called and receiving the WasShown signal from the RenderWidgetHost. If the test invokes SynchronousComposite before WasShown the BeginMainFrame is aborted. If a test is waiting on e.g. a requestAnimationFrame it will timeout. This CL fixes this by detecting this situation and scheduling a new frame when the widget becomes shown. Bug: 1466250 Change-Id: I218f5ed18bbbf0a1c176fbf562aa5ae939a3adcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4956092 Commit-Queue: David Bokan <[email protected]> Reviewed-by: Khushal Sagar <[email protected]> Reviewed-by: Xianzhu Wang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1214522}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4956092
branch
from
fb3a239 to
9fa894f
Compare
Slow tests
These may be pre-existing or newly slow tests. Slow tests indicate that a test ran very close to the test timeout limit and so may become TIMEOUT-flaky in the future. Consider speeding up the test or breaking it into multiple tests. For help, please tag |
|
Created crbug.com/1495795, @KyleJu @jcscottiii can you help admin merge? Thanks! |
KyleJu
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pagerevealevent will be specified and shipped separately fromview transitions so move tests into WPT. Since the spec is still WIP
these tests are marked tentative for now.
Tests that were specifically dealing with usage of the
viewTransitionattribute and its behavior in relation to a view transition were left in
the wpt_internal directory for view-transitions since those seems
specific to that feature.
Review note: PS#1 moves the files, diff from it to see changes.
These tests need to run in the no-forced-frame-update virtual test suite
since they're testing event order before rendering begins. WPT tests run
in single-threaded-mode which does not prevent scheduling frames before
rendering begins. This suite was added for other similar tests.
Additionally, there is a race during prerender activation between a
SynchronousComposite being called and receiving the WasShown signal from
the RenderWidgetHost. If the test invokes SynchronousComposite before
WasShown the BeginMainFrame is aborted. If a test is waiting on e.g. a
requestAnimationFrame it will timeout. This CL fixes this by detecting
this situation and scheduling a new frame when the widget becomes shown.
Bug: 1466250
Change-Id: I218f5ed18bbbf0a1c176fbf562aa5ae939a3adcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4956092
Commit-Queue: David Bokan <[email protected]>
Reviewed-by: Khushal Sagar <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1214522}