Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UIA aria-readonly mappings #42551

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update UIA aria-readonly mappings #42551

wants to merge 1 commit into from

Conversation

sivakusayan
Copy link
Contributor

WPT tests to match update in w3c/core-aam#203

@sivakusayan sivakusayan mentioned this pull request Oct 16, 2023
Merged
@cookiecrook cookiecrook assigned spectranaut and unassigned jnurthen Oct 18, 2023
@cookiecrook
Copy link
Contributor

Closing and reopening to kick CI past last week's spurious failures.

@cookiecrook cookiecrook reopened this Oct 18, 2023
spectranaut
spectranaut requested changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you accept these changes, we can merge :)

core-aam/aria-readonly_true_on-spinbutton-manual.html
"RangeValue.IsReadOnly",
"is",
"true"
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the discussion on the PR against core-aam, this should also have AriaProperties.readonly exposed

Suggested change
]
],
[
"property",
"AriaProperties.readonly",
"is",
"true"
]

core-aam/aria-readonly_true_on_combobox-manual.html
"Value.IsReadOnly",
"is",
"true"
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
]
],
[
"property",
"AriaProperties.readonly",
"is",
"true"
]

core-aam/aria-readonly_true_on_slider-manual.html
"RangeValue.IsReadOnly",
"is",
"true"
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
]
],
[
"property",
"AriaProperties.readonly",
"is",
"true"
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spectranaut spectranaut spectranaut requested changes

@jnurthen jnurthen Awaiting requested review from jnurthen

@joanmarie joanmarie Awaiting requested review from joanmarie

@michael-n-cooper michael-n-cooper Awaiting requested review from michael-n-cooper

Requested changes must be addressed to merge this pull request.

Assignees

@spectranaut spectranaut

Labels
core-aam manual
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sivakusayan @cookiecrook @spectranaut @jnurthen @wpt-pr-bot