Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pattern for role none/generic match. #42203

Merged

Conversation

cookiecrook
Copy link
Contributor

<area shape="rect" coords="15,15,31,31" alt="x" data-testname="el-area-no-href" data-expectedrole="generic" class="ex">
<area shape="rect" coords="15,15,31,31" alt="x" data-testname="el-area-no-href" class="ex-generic">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI reviewers, this PR just updates a few older tests that expect a specific role match with the implementation-specific acceptable alternates ["none" | "generic" | ""] as agreed upon in web-platform-tests/interop-accessibility#48

@cookiecrook cookiecrook assigned cookiecrook and unassigned jnurthen Sep 27, 2023
@cookiecrook cookiecrook enabled auto-merge (squash) October 3, 2023 19:53
@jnurthen jnurthen requested a review from rahimabdi October 5, 2023 17:28
Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cookiecrook cookiecrook merged commit 7177c46 into web-platform-tests:master Oct 10, 2023
19 checks passed
@cookiecrook cookiecrook deleted the generic-role-retrofit branch October 11, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update most tests with data-expectedrole="none" to match the new pattern in ./html-aam/roles-generic.html
4 participants