Add tests for computed label #41463
Merged
Add tests for computed label #41463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cookiecrook
reviewed
Aug 15, 2023
Co-authored-by: James Craig <[email protected]>
Co-authored-by: James Craig <[email protected]>
|
@cookiecrook I will give this a re-review and ping you once it's ready. Apologies for the delay! |
added 14 commits
October 22, 2023 13:45
jugglinmike
reviewed
Oct 26, 2023
added 6 commits
October 26, 2023 15:30
added 2 commits
November 8, 2023 15:51
cookiecrook
reviewed
Nov 9, 2023
cookiecrook
reviewed
Nov 9, 2023
accname/name/comp_label.html
Outdated
Comment on lines
239
to
241
| <button aria-label=" | ||
| " data-testname="button with carriage return as aria-label does not use aria-label as name" data-ignoredattributeforlabel="aria-label" class="ignore-attribute">my button</button> | ||
| <button aria-label=" " data-testname="button with space characters as aria-label does not use aria-label as name" data-ignoredattributeforlabel="aria-label" class="ignore-attribute">my button</button> |
There was a problem hiding this comment.
I think these two can be standard tests too, right? data-expectedlabel="my button" class="ex"
There was a problem hiding this comment.
Agreed; updated as part of de1eefe.
cookiecrook
reviewed
Nov 9, 2023
Co-authored-by: James Craig <[email protected]>
Co-authored-by: James Craig <[email protected]>
rahimabdi
previously approved these changes
Nov 10, 2023
rahimabdi
dismissed
their stale review
Requires another round of review, dismissing.
cookiecrook
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves web-platform-tests/interop-accessibility#34
Have a few questions, so leaving in draft status until resolved.