-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove XRSessionDeviceConfig.uses_input_eventing and related code #40530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
a52d298
to
5c7d539
Compare
This commit removes the uses_input_eventing_ variable from the XRSessionDeviceConfig interface and all the code that relied on it. The XRSessionDeviceConfig.uses_input_eventing feature was originally added to support WMR but is no longer needed since no runtimes support it now. Bug: 1429644 Change-Id: I6d691f67e20d5f430169556b215e038c6b1c3173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604546 Quick-Run: Alexander Cooper <[email protected]> Reviewed-by: Alex Gough <[email protected]> Reviewed-by: Alexander Cooper <[email protected]> Commit-Queue: Alexander Cooper <[email protected]> Cr-Commit-Position: refs/heads/main@{#1157619}
5c7d539
to
ff7c74e
Compare
Uh oh! Looks like an error! DetailsClient ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:
This request requires the client to satisfy the following scope expression:
|
Uh oh! Looks like an error! DetailsClient ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:
This request requires the client to satisfy the following scope expression:
|
This commit removes the uses_input_eventing_ variable from the
XRSessionDeviceConfig interface and all the code that relied on it.
The XRSessionDeviceConfig.uses_input_eventing feature was originally
added to support WMR but is no longer needed since no runtimes support
it now.
Bug: 1429644
Change-Id: I6d691f67e20d5f430169556b215e038c6b1c3173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604546
Quick-Run: Alexander Cooper <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Alexander Cooper <[email protected]>
Commit-Queue: Alexander Cooper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157619}