Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XRSessionDeviceConfig.uses_input_eventing and related code #40530

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 13, 2023

This commit removes the uses_input_eventing_ variable from the
XRSessionDeviceConfig interface and all the code that relied on it.
The XRSessionDeviceConfig.uses_input_eventing feature was originally
added to support WMR but is no longer needed since no runtimes support
it now.

Bug: 1429644
Change-Id: I6d691f67e20d5f430169556b215e038c6b1c3173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604546
Quick-Run: Alexander Cooper <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Alexander Cooper <[email protected]>
Commit-Queue: Alexander Cooper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157619}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-4604546 branch 2 times, most recently from a52d298 to 5c7d539 Compare June 13, 2023 22:57
This commit removes the uses_input_eventing_ variable from the
XRSessionDeviceConfig interface and all the code that relied on it.
The XRSessionDeviceConfig.uses_input_eventing feature was originally
added to support WMR but is no longer needed since no runtimes support
it now.

Bug: 1429644
Change-Id: I6d691f67e20d5f430169556b215e038c6b1c3173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4604546
Quick-Run: Alexander Cooper <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Alexander Cooper <[email protected]>
Commit-Queue: Alexander Cooper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157619}
@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/O-HNwCBaQaWa7QZ7CtMrcw/EhGM_KNkTD2zI3iTcrhZXg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/O-HNwCBaQaWa7QZ7CtMrcw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/O-HNwCBaQaWa7QZ7CtMrcw/EhGM_KNkTD2zI3iTcrhZXg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/O-HNwCBaQaWa7QZ7CtMrcw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-06-15T20:54:24.425Z

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/O-HNwCBaQaWa7QZ7CtMrcw/Fx38QlkgRX6sV-jOcggsiA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/O-HNwCBaQaWa7QZ7CtMrcw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/O-HNwCBaQaWa7QZ7CtMrcw/Fx38QlkgRX6sV-jOcggsiA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/O-HNwCBaQaWa7QZ7CtMrcw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-06-15T20:54:24.652Z

@nihardamar nihardamar closed this Jun 15, 2023
@nihardamar nihardamar reopened this Jun 15, 2023
@nihardamar nihardamar merged commit 866ccc0 into master Jun 15, 2023
@nihardamar nihardamar deleted the chromium-export-cl-4604546 branch June 15, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants