Convert :open to :popover-open for popovers
#39222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 27, 2023
4 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4373888
branch
3 times, most recently
from
80d0037 to
f0c8874
Compare
chromium-wpt-export-bot
changed the title
:open to :popover for popovers:open to :popover-open for popovers
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4373888
branch
2 times, most recently
from
e6a34df to
f7dc063
Compare
See [1]/[2] for more context, but there are cases where `:open` is ambiguous for popovers. If multiple elements support `:open/:closed`, and [popover] can be applied to any of them, there are situations where an element is both open and closed. For example, `<details popover>` can be closed as a details element and open as a popover, which makes it match both `:open` and `:closed`. It seems that really `:open` and `:closed` should match *elements* that can open and close, and not things that can be made to open or close via an attribute or other mechanism such as JS. This CL adds `:popover-open` which only applies to popovers in the open state, and it removes `:open` and `:closed` support for popovers. It also converts all of the popover WPTs to use `:popover-open` instead of either `:open` or `:closed`. [1] w3c/csswg-drafts#8637 [2] whatwg/html#9077 Bug: 1307772 Fixed: 1429670 Change-Id: I8d840512166ccdb5d5c8abbb7192bbce7177ee88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4373888 Reviewed-by: Joey Arhar <[email protected]> Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1124869}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4373888
branch
from
f7dc063 to
f279783
Compare
annevk
pushed a commit
to whatwg/html
that referenced
this pull request
Apr 3, 2023
As discussed in w3c/csswg-drafts#8637. Tests: web-platform-tests/wpt#39222.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See [1]/[2] for more context, but there are cases where
:openisambiguous for popovers. If multiple elements support
:open/:closed,and [popover] can be applied to any of them, there are situations
where an element is both open and closed. For example,
\<details popover>can be closed as a details element and open asa popover, which makes it match both
:openand:closed. It seemsthat really
:openand:closedshould match elements that canopen and close, and not things that can be made to open or close
via an attribute or other mechanism such as JS.
This CL adds
:popover-openwhich only applies to popovers in the openstate, and it removes
:openand:closedsupport for popovers. It also converts all of the popover WPTs to use:popover-openinsteadof either
:openor:closed.[1] w3c/csswg-drafts#8637
[2] whatwg/html#9077
Bug: 1307772
Fixed: 1429670
Change-Id: I8d840512166ccdb5d5c8abbb7192bbce7177ee88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4373888
Reviewed-by: Joey Arhar <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1124869}