Use (site, site) for SAA grants #38908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 9, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4307251
branch
4 times, most recently
from
37d0072 to
3f6a822
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4307251
branch
4 times, most recently
from
d126995 to
6b2b814
Compare
This updates storage-access permissions to apply on an (embedded site, top-level site) scope as detailed in privacycg/storage-access#159. For adding WPT tests, I patched up the web_test_permission_manager to special-case the storage-access permission to (site, site) scope. I kept things intentionally simple for now but we could consider abstracting out the scope into a "permission key" concept in that file, as it is done in the permissions spec now. There's follow-up work here to make this (and the existing top-level site scope) sync up with the scope that is defined in content settings, see https://crbug.com/1422971 Bug: 1418470 Change-Id: I316f682d24d962f79fcac332365790bca383c6ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4307251 Reviewed-by: danakj <[email protected]> Commit-Queue: Johann Hofmann <[email protected]> Reviewed-by: Christian Dullweber <[email protected]> Cr-Commit-Position: refs/heads/main@{#1120269}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4307251
branch
from
6b2b814 to
0518544
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates storage-access permissions to apply on an (embedded site,
top-level site) scope as detailed in
privacycg/storage-access#159.
For adding WPT tests, I patched up the web_test_permission_manager to
special-case the storage-access permission to (site, site) scope. I kept
things intentionally simple for now but we could consider abstracting
out the scope into a "permission key" concept in that file, as it is
done in the permissions spec now.
There's follow-up work here to make this (and the existing top-level
site scope) sync up with the scope that is defined in content settings,
see https://crbug.com/1422971
Bug: 1418470
Change-Id: I316f682d24d962f79fcac332365790bca383c6ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4307251
Reviewed-by: danakj <[email protected]>
Commit-Queue: Johann Hofmann <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1120269}