Update popover events test to check bubbles/cancelable #38657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 22, 2023
Per a request [1], this adds a few more checks to ensure the toggle events have the right values for bubbles and cancelable. [1] whatwg/html#8888 (comment) Bug: 1307772 Change-Id: I8f3116703bbcb9dbc98df9be25c1fa03b7c2b97c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4278524 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Auto-Submit: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1108470}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4278524
branch
from
ec6be79 to
4f76b5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per a request [1], this adds a few more checks to ensure the toggle
events have the right values for bubbles and cancelable.
[1] whatwg/html#8888 (comment)
Bug: 1307772
Change-Id: I8f3116703bbcb9dbc98df9be25c1fa03b7c2b97c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4278524
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1108470}