Stop bubbling for popover toggle events #38571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 17, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4263380
branch
from
47e389e to
1e6a5b9
Compare
Per the discussion at [1], this was an oversight and popover toggle events (`beforetoggle` and `toggle`) should not bubble. [1] whatwg/html#8888 Closes: whatwg/html#8888 Bug: 1307772 Change-Id: I29e286a6f9a8bcd1d725fa85e200a388bde0323c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4263380 Commit-Queue: Joey Arhar <[email protected]> Commit-Queue: Mason Freed <[email protected]> Auto-Submit: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1106907}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4263380
branch
from
1e6a5b9 to
0a39c5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion at [1], this was an oversight and popover toggle
events (
beforetoggleandtoggle) should not bubble.[1] whatwg/html#8888
Closes: whatwg/html#8888
Bug: 1307772
Change-Id: I29e286a6f9a8bcd1d725fa85e200a388bde0323c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4263380
Commit-Queue: Joey Arhar <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1106907}