Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Cache-Control and Pragma headers when If-None-Match is set #37986

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Test Cache-Control and Pragma headers when If-None-Match is set #37986

wants to merge 1 commit into from

Conversation

jgraham
Copy link
Contributor

@jgraham jgraham commented Jan 16, 2023

These should be set to no-store.

This test is required for the web compatibility focus area of Interop 2023.

@jgraham jgraham mentioned this pull request Jan 16, 2023
Closed
@annevk
Copy link
Member

annevk commented Jan 16, 2023

Note that as per whatwg/fetch#722 these headers are somewhat controversial.

We should also test that Pragma and Cache-Control don't get overridden if already set, presumably?

@annevk annevk mentioned this pull request Feb 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk Awaiting requested review from annevk

@deniak deniak Awaiting requested review from deniak

@jdm jdm Awaiting requested review from jdm

@mnot mnot Awaiting requested review from mnot

@youennf youennf Awaiting requested review from youennf

@yutakahirano yutakahirano Awaiting requested review from yutakahirano

@zqzhang zqzhang Awaiting requested review from zqzhang

At least 1 approving review is required to merge this pull request.

Assignees

@deniak deniak

Labels
assets fetch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgraham @annevk @deniak @wpt-pr-bot