Allow Progress element to have writing mode vertical #36659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 26, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3979781
branch
5 times, most recently
from
481366b to
a5672b5
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3979781
branch
from
a5672b5 to
8685439
Compare
4 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3979781
branch
3 times, most recently
from
bbc07fa to
a3fa0d0
Compare
This CL allow <progress> element to have writing-mode vertical for both the default native appearance and when appearance is set to none. We also add the feature flag FormControlsVerticalWritingModeSupport so all changes made for this bug can be turned on/off safely. Change-Id: I2e1d424d4337b42316e830cfbb16afb053699bc5 Bug: 681917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3979781 Reviewed-by: Mason Freed <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Reviewed-by: Evan Stade <[email protected]> Commit-Queue: Di Zhang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1068912}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3979781
branch
from
a3fa0d0 to
4d9e92d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL allow <progress> element to have writing-mode vertical for
both the default native appearance and when appearance is set to none.
We also add the feature flag FormControlsVerticalWritingModeSupport so
all changes made for this bug can be turned on/off safely.
Change-Id: I2e1d424d4337b42316e830cfbb16afb053699bc5
Bug: 681917
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3979781
Reviewed-by: Mason Freed <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Di Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1068912}