[SPC] Rename rp --> rpId in CollectedClientAdditionalPaymentData #35602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As expected, Chrome regresses on this test change. Tracking bug: https://crbug.com/1356224 |
ianbjacobs
approved these changes
Aug 25, 2022
stephenmcgruer
added a commit
to w3c/secure-payment-confirmation
that referenced
this pull request
Aug 25, 2022
To align with WebAuthn, we should use the term rpId here. This is a breaking change, but implementations can mitigate the breakage by continuing to include the old 'rp' name going forwards. See #191 Test changes: web-platform-tests/wpt#35602 Implementation bugs: Chrome: https://crbug.com/1356224 Safari: N/A Firefox: N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See w3c/secure-payment-confirmation#198