Convert popup=popup to popup=auto or just popup
#34217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 26, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3668816
branch
3 times, most recently
from
1b27850 to
81d4d47
Compare
Per the [1] resolution, `popup=popup` has been renamed to `popup=auto`.
Additionally, per the [2] resolution, "boolean-like" behavior is also
supported, such that `<div popup>` means the same thing as `<div popup=auto>`. This CL implements both of these changes.
Note that this CL has one case that still needs to be fixed:
<div id=foo popup=invalid>
<script>
foo.popup === null; // false, should be true
</script>
To fix the above, I need to figure out how to specify the ReflectMissing
and ReflectInvalid values so that they mean "null".
[1] openui/open-ui#491 (comment)
[2] openui/open-ui#533 (comment)
Bug: 1307772
Change-Id: I6037c5322f7408ebd2c91690f89ecbc513c66bdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3668816
Auto-Submit: Mason Freed <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Reviewed-by: Aaron Leventhal <[email protected]>
Reviewed-by: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1009383}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3668816
branch
from
81d4d47 to
d2bd43c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the [1] resolution,
popup=popuphas been renamed topopup=auto.Additionally, per the [2] resolution, "boolean-like" behavior is also
supported, such that
\<div popup>means the same thing as\<div popup=auto>. This CL implements both of these changes.Note that this CL has one case that still needs to be fixed:
<div id=foo popup=invalid>
<script>
foo.popup === null; // false, should be true
</script>
To fix the above, I need to figure out how to specify the ReflectMissing
and ReflectInvalid values so that they mean "null".
[1] openui/open-ui#491 (comment)
[2] openui/open-ui#533 (comment)
Bug: 1307772
Change-Id: I6037c5322f7408ebd2c91690f89ecbc513c66bdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3668816
Auto-Submit: Mason Freed <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Reviewed-by: Aaron Leventhal <[email protected]>
Reviewed-by: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1009383}