Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for default aria-valuenow set to undefined in ARIA 1.2 #33680

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spectranaut
Copy link
Contributor

See changes: w3c/aria@d6a99dec

Copy link
Contributor Author

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joanmarie I'm trying to wrap my head around what would have to change in order to support the new no default aria-valuenow attribute on a spinbutton. Can you take a look at this?

"property",
"currentValue",
"is",
"VT_EMPTY"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is a valid test, but it looks like there is support for a value to have "no value" already in Chrome for this API: https://source.chromium.org/chromium/chromium/src/+/main:ui/accessibility/platform/ax_platform_node_win.cc;l=4580?q=VT_EMPTY%20f:_win.cc

"atk_value_get_current_value()",
"is",
"0"
]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ATK API returns value as a GValue, which I think is a float, so I'm not sure a default value could be anything other than 0?

"property",
"RangeValue.Value",
"is",
"0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"property",
"accValue",
"is",
""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a string representation of the value, so can be empty string: https://docs.microsoft.com/en-us/windows/win32/api/oleacc/nf-oleacc-iaccessible-get_accvalue

"property",
"AXValue",
"is",
""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants