Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streams: reject pending reads when releasing reader #32072

Merged
merged 14 commits into from
Jan 13, 2022
Merged

Streams: reject pending reads when releasing reader #32072

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
bb9b791
Tests whether releaseLock() rejects all pending reads
MattiasBuelens Oct 14, 2021
134eb95
Test whether second reader can read chunks after first reader was rel…
MattiasBuelens Dec 15, 2021
78367f8
Test whether pending reads are rejected on a BYOB reader
MattiasBuelens Dec 15, 2021
bb39155
Test reads with second BYOB reader after releasing first BYOB reader
MattiasBuelens Dec 15, 2021
084f8ae
Move assert_typed_array_equals to test-utils
MattiasBuelens Dec 15, 2021
04f6e39
Simplify checks
MattiasBuelens Dec 15, 2021
d8983ec
Fix typos
MattiasBuelens Dec 15, 2021
7b4900b
Test using respondWithNewView() and enqueue()
MattiasBuelens Dec 15, 2021
d17ca71
Test with autoAllocateChunkSize
MattiasBuelens Dec 15, 2021
d751915
Test more tricky cases with multi-byte typed arrays
MattiasBuelens Dec 15, 2021
0bf764b
Test close() + respond(0) after releasing first BYOB reader
MattiasBuelens Jan 11, 2022
3c8ce1f
Test whether respondWithNewView() throws if view.byteOffset is incorrect
MattiasBuelens Jan 11, 2022
ac0f52e
Use assert_true and assert_false
MattiasBuelens Jan 12, 2022
7dc156a
Fix assert messages
MattiasBuelens Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions streams/readable-byte-streams/bad-buffers-and-views.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,38 @@ async_test(t => {
}, 'ReadableStream with byte source: respondWithNewView() throws if the supplied view is zero-length on a ' +
'non-zero-length buffer (in the readable state)');

async_test(t => {
const stream = new ReadableStream({
pull: t.step_func_done(c => {
const view = c.byobRequest.view.subarray(1, 2);

assert_throws_js(RangeError, () => c.byobRequest.respondWithNewView(view));
}),
type: 'bytes'
});
const reader = stream.getReader({ mode: 'byob' });

reader.read(new Uint8Array([4, 5, 6]));
}, 'ReadableStream with byte source: respondWithNewView() throws if the supplied view has a different offset ' +
'(in the readable state)');
Comment on lines +218 to +219
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by fix: I noticed that this check was not covered by any tests, so I added one. 🙂


async_test(t => {
const stream = new ReadableStream({
pull: t.step_func_done(c => {
c.close();

const view = c.byobRequest.view.subarray(1, 1);

assert_throws_js(RangeError, () => c.byobRequest.respondWithNewView(view));
}),
type: 'bytes'
});
const reader = stream.getReader({ mode: 'byob' });

reader.read(new Uint8Array([4, 5, 6]));
}, 'ReadableStream with byte source: respondWithNewView() throws if the supplied view has a different offset ' +
'(in the closed state)');

async_test(t => {
const stream = new ReadableStream({
pull: t.step_func_done(c => {
Expand Down
Loading