Exclude browser stability tests for exports from that specific browser #31898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgraham
reviewed
Dec 6, 2021
tools/ci/tc/decision.py
Outdated
| all_jobs.discard("wpt-firefox-nightly-stability") | ||
| except KeyError: | ||
| # Just continue if the username cannot be pulled from the event. | ||
| logger.info("Unable to read username from event. Continuing.") |
There was a problem hiding this comment.
I'm not even sure we need to log this, but if we are maybe make it debug level.
There was a problem hiding this comment.
I changed it to a debug level log👌
tools/ci/tc/decision.py
Outdated
| @@ -74,6 +74,17 @@ def get_run_jobs(event): | |||
| path_jobs = jobs.get_jobs(paths) | |||
| all_jobs = path_jobs | get_extra_jobs(event) | |||
| logger.info("Including jobs:\n * %s" % "\n * ".join(all_jobs)) | |||
|
|
|||
| # Exclude browser stability tests for exports from that specific browser. | |||
| try: | |||
There was a problem hiding this comment.
Can we put this in a filter_jobs function, and call it before the Including jobs log line?
There was a problem hiding this comment.
Great idea - implemented
DanielRyanSmith
commented
Dec 6, 2021
tools/ci/tc/decision.py
Outdated
| @@ -100,6 +102,19 @@ def get_extra_jobs(event): | |||
| return jobs | |||
|
|
|||
|
|
|||
| def filter_jobs(jobs: Set, event: Dict) -> None: | |||
There was a problem hiding this comment.
Flake8 is upset about this line not using typing.Set and typing.Dict, but these are deprecated as of Python 3.9. I'm just going to remove the type hints.
foolip
approved these changes
Dec 7, 2021
foolip
changed the title
|
I've renamed the PR since this now does both Chrome and Firefox. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29737