Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPT tests for COOP with Reporting-Endpoints header #31099

Merged
merged 1 commit into from
Nov 3, 2021
Merged

WPT tests for COOP with Reporting-Endpoints header #31099

merged 1 commit into from
Nov 3, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Oct 4, 2021 •
edited
Loading

  • Test the integration between new Reporting-Endpoints header
    with coop reporters
  • Added new cases covering reports sent from redirects.

Bug: 1209057, 1062359
Change-Id: I2e061f2f9e235264d569032204c75df30cdb5220
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202651
Commit-Queue: Rodney Ding <[email protected]>
Reviewed-by: Ian Clelland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#937859}

@wpt-pr-bot wpt-pr-bot added the html label Oct 4, 2021
wpt-pr-bot
wpt-pr-bot approved these changes Oct 4, 2021
View reviewed changes
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-3202651 branch 2 times, most recently from 96900ef to 007a087 Compare October 5, 2021 03:36
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-3202651 branch 2 times, most recently from 612dc82 to d139e87 Compare October 21, 2021 01:16
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-3202651 branch 2 times, most recently from bab7334 to c9e02e5 Compare November 3, 2021 01:20
@r0dneyP3 @chromium-wpt-export-bot
WPT tests for COOP with Reporting-Endpoints header
8c06e7a 
* Test the integration between new Reporting-Endpoints header
  with coop reporters
* Added new cases covering reports sent from redirects.

Bug: 1209057, 1062359
Change-Id: I2e061f2f9e235264d569032204c75df30cdb5220
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202651
Commit-Queue: Rodney Ding <[email protected]>
Reviewed-by: Ian Clelland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#937859}
@past
Copy link
Member

past commented Nov 3, 2021

Some affected tests had inconsistent (flaky) results in Chrome Dev:

Unstable results

Test Subtest Results Messages
/html/cross-origin-opener-policy/reporting/access-reporting/access-from-coop-page-to-openee_coop-ro.https.html   CRASH: 1/10, OK: 9/10  
/html/cross-origin-opener-policy/reporting/access-reporting/access-from-coop-page-to-openee_coop-ro.https.html access-from-coop-page-to-openee, same-origin FAIL: 9/10, MISSING: 1/10 assert_equals: expected (string) "coop" but got (undefined) undefined
/html/cross-origin-opener-policy/reporting/access-reporting/access-from-coop-page-to-openee_coop-ro.https.html access-from-coop-page-to-openee, same-origin + redirect FAIL: 9/10, MISSING: 1/10 assert_equals: expected (string) "coop" but got (undefined) undefined
/html/cross-origin-opener-policy/reporting/access-reporting/access-to-coop-page-from-openee_coop-ro_cross-origin.https.html   CRASH: 1/10, OK: 9/10  
/html/cross-origin-opener-policy/reporting/access-reporting/access-to-coop-page-from-openee_coop-ro_cross-origin.https.html access-to-coop-page-from-openee, cross-origin PASS: 9/10, MISSING: 1/10  
/html/cross-origin-opener-policy/reporting/access-reporting/access-to-coop-page-from-openee_coop-ro_cross-origin.https.html access-to-coop-page-from-openee, cross-origin + redirect) PASS: 9/10, MISSING: 1/10  
/html/cross-origin-opener-policy/reporting/access-reporting/access-to-coop-page-from-other_coop-ro.https.html   CRASH: 2/10, OK: 8/10  
/html/cross-origin-opener-policy/reporting/access-reporting/access-to-coop-page-from-other_coop-ro.https.html access-to-coop-page-from-other (COOP-RO) PASS: 8/10, MISSING: 2/10  
/html/cross-origin-opener-policy/reporting/access-reporting/property-closed.https.html   CRASH: 1/10, OK: 9/10  
/html/cross-origin-opener-policy/reporting/access-reporting/property-closed.https.html same-origin > w => w.closed FAIL: 9/10, MISSING: 1/10 promise_test: Unhandled rejection with value: object "TypeError: Cannot read properties of undefined (reading 'property')"
/html/cross-origin-opener-policy/reporting/access-reporting/property-closed.https.html cross-origin > w => w.closed FAIL: 9/10, MISSING: 1/10 promise_test: Unhandled rejection with value: object "TypeError: Cannot read properties of undefined (reading 'property')"
/html/cross-origin-opener-policy/reporting/access-reporting/property-location-get.https.html   CRASH: 1/10, OK: 9/10  
/html/cross-origin-opener-policy/reporting/access-reporting/property-location-get.https.html same-origin > w => w.location FAIL: 9/10, MISSING: 1/10 promise_test: Unhandled rejection with value: object "TypeError: Cannot read properties of undefined (reading 'property')"
/html/cross-origin-opener-policy/reporting/access-reporting/property-location-get.https.html cross-origin > w => w.location FAIL: 9/10, MISSING: 1/10 promise_test: Unhandled rejection with value: object "TypeError: Cannot read properties of undefined (reading 'property')"
/html/cross-origin-opener-policy/reporting/access-reporting/property-opener-set.https.html   CRASH: 1/10, OK: 9/10  
/html/cross-origin-opener-policy/reporting/access-reporting/property-opener-set.https.html same-origin > w => w.opener = "" PASS: 9/10, MISSING: 1/10  
/html/cross-origin-opener-policy/reporting/access-reporting/property-opener-set.https.html cross-origin > w => w.opener = "" PASS: 9/10, MISSING: 1/10  
/html/cross-origin-opener-policy/reporting/access-reporting/property-postmessage-1.https.html   CRASH: 3/10, OK: 7/10  
/html/cross-origin-opener-policy/reporting/access-reporting/property-postmessage-1.https.html same-origin > w => w.postMessage("", "") FAIL: 7/10, MISSING: 3/10 promise_test: Unhandled rejection with value: object "TypeError: Cannot read properties of undefined (reading 'property')"
/html/cross-origin-opener-policy/reporting/access-reporting/property-postmessage-1.https.html cross-origin > w => w.postMessage("", "") FAIL: 7/10, MISSING: 3/10 promise_test: Unhandled rejection with value: object "TypeError: Cannot read properties of undefined (reading 'property')"
/html/cross-origin-opener-policy/reporting/access-reporting/property-self.https.html   CRASH: 4/10, OK: 6/10  
/html/cross-origin-opener-policy/reporting/access-reporting/property-self.https.html same-origin > w => w.self FAIL: 6/10, MISSING: 4/10 promise_test: Unhandled rejection with value: object "TypeError: Cannot read properties of undefined (reading 'property')"
/html/cross-origin-opener-policy/reporting/access-reporting/property-self.https.html cross-origin > w => w.self FAIL: 6/10, MISSING: 4/10 promise_test: Unhandled rejection with value: object "TypeError: Cannot read properties of undefined (reading 'property')"
/html/cross-origin-opener-policy/reporting/navigation-reporting/report-only-four-reports.https.html verify remaining reports FAIL: 3/10, PASS: 7/10 assert_equals: coop-report-endpoint should be empty expected 0 but got 1;assert_equals: coop-report-only-endpoint should be empty expected 0 but got 1

@past
Copy link
Member

past commented Nov 3, 2021

Some affected tests had inconsistent (flaky) results in Firefox Nightly:

Unstable results

Test Subtest Results Messages
/html/cross-origin-opener-policy/reporting/access-reporting/access-from-coop-page-to-other_coop-ro_cross-origin.https.html   CRASH: 2/10, OK: 8/10  
/html/cross-origin-opener-policy/reporting/access-reporting/access-from-coop-page-to-other_coop-ro_cross-origin.https.html access-from-coop-page-to-other (COOP-RO) FAIL: 8/10, MISSING: 2/10 assert_equals: expected (string) "coop" but got (undefined) undefined
/html/cross-origin-opener-policy/reporting/access-reporting/access-to-coop-page-from-other_coop-ro_cross-origin.https.html   OK: 9/10, TIMEOUT: 1/10  
/html/cross-origin-opener-policy/reporting/access-reporting/access-to-coop-page-from-other_coop-ro_cross-origin.https.html access-to-coop-page-from-other (COOP-RO) FAIL: 9/10, MISSING: 1/10 assert_equals: expected (string) "coop" but got (undefined) undefined
/html/cross-origin-opener-policy/reporting/access-reporting/property-blur.https.html   CRASH: 2/10, OK: 8/10  
/html/cross-origin-opener-policy/reporting/access-reporting/property-blur.https.html same-origin > w => w.blur() FAIL: 8/10, MISSING: 2/10 promise_test: Unhandled rejection with value: object "TypeError: can't access property "property", report.body is undefined"
/html/cross-origin-opener-policy/reporting/access-reporting/property-blur.https.html cross-origin > w => w.blur() FAIL: 8/10, MISSING: 2/10 promise_test: Unhandled rejection with value: object "TypeError: can't access property "property", report.body is undefined"
/html/cross-origin-opener-policy/reporting/access-reporting/property-focus.https.html   CRASH: 2/10, OK: 7/10, TIMEOUT: 1/10  
/html/cross-origin-opener-policy/reporting/access-reporting/property-focus.https.html same-origin > w => w.focus() FAIL: 7/10, MISSING: 3/10 promise_test: Unhandled rejection with value: object "TypeError: can't access property "property", report.body is undefined"
/html/cross-origin-opener-policy/reporting/access-reporting/property-focus.https.html cross-origin > w => w.focus() FAIL: 7/10, MISSING: 3/10 promise_test: Unhandled rejection with value: object "TypeError: can't access property "property", report.body is undefined"
/html/cross-origin-opener-policy/reporting/access-reporting/property-frames.https.html   CRASH: 1/10, OK: 9/10  
/html/cross-origin-opener-policy/reporting/access-reporting/property-frames.https.html same-origin > w => w.frames FAIL: 9/10, MISSING: 1/10 promise_test: Unhandled rejection with value: object "TypeError: can't access property "property", report.body is undefined"
/html/cross-origin-opener-policy/reporting/access-reporting/property-frames.https.html cross-origin > w => w.frames FAIL: 9/10, MISSING: 1/10 promise_test: Unhandled rejection with value: object "TypeError: can't access property "property", report.body is undefined"
/html/cross-origin-opener-policy/reporting/access-reporting/property-top.https.html   OK: 9/10, TIMEOUT: 1/10  
/html/cross-origin-opener-policy/reporting/access-reporting/property-top.https.html same-origin > w => w.top FAIL: 9/10, MISSING: 1/10 promise_test: Unhandled rejection with value: object "TypeError: can't access property "property", report.body is undefined"
/html/cross-origin-opener-policy/reporting/access-reporting/property-top.https.html cross-origin > w => w.top FAIL: 9/10, MISSING: 1/10 promise_test: Unhandled rejection with value: object "TypeError: can't access property "property", report.body is undefined"
/html/cross-origin-opener-policy/reporting/access-reporting/property-window.https.html   OK: 9/10, TIMEOUT: 1/10  
/html/cross-origin-opener-policy/reporting/access-reporting/property-window.https.html same-origin > w => w.window FAIL: 9/10, MISSING: 1/10 promise_test: Unhandled rejection with value: object "TypeError: can't access property "property", report.body is undefined"
/html/cross-origin-opener-policy/reporting/access-reporting/property-window.https.html cross-origin > w => w.window FAIL: 9/10, MISSING: 1/10 promise_test: Unhandled rejection with value: object "TypeError: can't access property "property", report.body is undefined"
/html/cross-origin-opener-policy/reporting/navigation-reporting/report-only-four-reports.https.html   OK: 9/10, TIMEOUT: 1/10  
/html/cross-origin-opener-policy/reporting/navigation-reporting/report-only-four-reports.https.html coop reporting test A test with both COOP and COOP report only setup to CROSS_ORIGIN with same-origin-allow-popups; report-to="coop-popup-report-endpoint", require-corp, same-origin; report-to="coop-popup-report-only-endpoint", require-corp FAIL: 9/10, MISSING: 1/10 promise_test: Unhandled rejection with value: "No report matched the expected report for endpoint: coop-report-endpoint, expected report: {"body":{"disposition":"enforce","effectivePolicy":"same-origin-allow-popups","nextResponseURL":"/uuid=(uuid)$/","type":"navigation-from-response"},"url":"https://web-platform.test:8443/html/cross-origin-opener-policy/reporting/navigation-reporting/report-only-four-reports.https.html\",\"type\":\"coop\"}, within available reports: []"
/html/cross-origin-opener-policy/reporting/navigation-reporting/report-only-four-reports.https.html verify remaining reports PASS: 9/10, MISSING: 1/10  

@past
Copy link
Member

past commented Nov 3, 2021

Filed https://crbug.com/1266527 for the flaky tests.

@past past merged commit 5b2e828 into master Nov 3, 2021
@past past deleted the chromium-export-cl-3202651 branch November 3, 2021 18:47
Gabisampaio pushed a commit to Gabisampaio/wpt that referenced this pull request Nov 18, 2021
@chromium-wpt-export-bot @r0dneyP3 @Gabisampaio
WPT tests for COOP with Reporting-Endpoints header (web-platform-test…
fad3b7b 
…s#31099)

* Test the integration between new Reporting-Endpoints header
  with coop reporters
* Added new cases covering reports sent from redirects.

Bug: 1209057, 1062359
Change-Id: I2e061f2f9e235264d569032204c75df30cdb5220
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202651
Commit-Queue: Rodney Ding <[email protected]>
Reviewed-by: Ian Clelland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#937859}

Co-authored-by: Rodney Ding <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

Assignees
No one assigned
Labels
chromium-export html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chromium-wpt-export-bot @past @wpt-pr-bot @r0dneyP3