-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BigInt64Array
and BigUint64Array
tests
#27920
Add BigInt64Array
and BigUint64Array
tests
#27920
Conversation
I think we should tests this in a couple other places as well, to ensure implementations end up supporting this correctly (or already support it correctly?):
|
Thanks, I'm not a big fan of making support conditional. Is that needed for some implementations? |
I think the first place I encountered missing support was The argument type for
I haven’t found anything defining what it means for an ArrayBufferView to be “of an integer type.” Web IDL does define “integer type,” but TypedArrays are ES objects whose indexed members model ES Number or BigInt language values. They have associated constraining “element types” (e.g. Int8), but despite the general alignment (e.g. Int8 → Byte), these aren’t really Web IDL integer values, so it doesn’t seem like the Web IDL term would be applicable here? Stepping back from muddling through a search for a formal answer about how to read this, though: does anybody know what the intention might have been? At the time this was written, I’d guess they specifically wished to forbid Float32Array and Float64Array ... and ... maybe forgot DataView exists? I dunno. If “of an integer type” really isn’t defined, I’d like to say big ones count (the most integer type of all, perhaps!) — but w/o knowing the rationale for the original constraint, I don’t feel confident making a case for that. |
@bathos that specification seems woefully imprecise. I recommend filing an issue. It does seem like something that ought to work. |
b97b333
to
74404bf
Compare
74404bf
to
6f4b713
Compare
BigInt64Array
and BigUint64Array
BigInt64Array
and BigUint64Array
tests
66fb6fe
to
8e7b5ba
Compare
Hi @web-platform-tests/wpt-core-team. I'd like to merge this PR, which changes idlharness and thus potentially affects a lot of tests. However, the stability bots are unhappy about some pre-existing flakes:
Is there a way to merge the PR anyway, despite the required statuses failing? |
@TimothyGu yes if you've looked into the flakiness and it's pre-existing / unrelated then we can admin merge and bypass requires CI checks. I'll do just that. |
Spec: whatwg/webidl#936
/cc @annevk @bathos